PHP 5.4+ shows the following error:

  • Strict warning: Declaration of nodequeue_handler_relationship_nodequeue::query() should be compatible with views_handler_relationship::query($group_by = false) in views_include_handler() (line 98 of sites/all/modules/contrib/views/includes/handlers.inc).
CommentFileSizeAuthor
#2 nodequeue-n2512892-2.patch661 bytesdamienmckenna
#1 nodequeue-n2512892-1.patch663 bytesdamienmckenna

Comments

damienmckenna’s picture

damienmckenna
Location TN, USA
commented
Status: Active » Needs review
StatusFileSize
new nodequeue-n2512892-1.patch663 bytes

This should resolve it.

damienmckenna’s picture

damienmckenna
Location TN, USA
commented
StatusFileSize
new nodequeue-n2512892-2.patch661 bytes

Slight copy/paste typoo, this one should work.

damienmckenna’s picture

damienmckenna
Location TN, USA
commented
Title: PHP 5.3 E_STRICT warning - declaration compatibility » PHP 5.4 E_STRICT warning - declaration compatibility
michelle’s picture

michelle
she/her
Primary language English
Location Wisconsin, USA
commented

I started looking into this but couldn't figure out where the error shows up. I'm not terribly familiar with Nodequeue and I am not seeing where it interacts with Views. Creating a Nodequeue and adding things to it doesn't seem to be sufficient. If you could point me in the right direction, I will finish reviewing this. :)

damienmckenna’s picture

damienmckenna
Location TN, USA
commented

You'd need a view that contained a relationship to the nodequeue.

michelle’s picture

michelle
she/her
Primary language English
Location Wisconsin, USA
commented
Status: Needs review » Reviewed & tested by the community

Ok, got it. I hadn't gone back to the main views list again after making the nodequeue to see there was an auto-created view there. So now I was able to see the error and confirm that this patch removes the error.

  • fizk committed 137c968 on 6.x-2.x authored by DamienMcKenna 
    Issue #2512892 by DamienMcKenna: PHP 5.4 E_STRICT warning - declaration...
fizk’s picture

fizk commented
Status: Reviewed & tested by the community » Patch (to be ported)

Thanks, I've committed this for 6.x-2.x.

Does this also affect 7.x-2.x?

fizk’s picture

fizk commented
Status: Patch (to be ported) » Fixed

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.