See the patch, for some reason my smartqueue's ->use_parents property isn't set,

Since everywhere it's referenced it gets wrapped in an isset seems sensible to do so in smartqueue_taxonomy_nodequeue_subqueues as well.

CommentFileSizeAuthor
#2 nodequeue-2386261-2.patch844 bytesdanepowell
nodequeue-use-parents-notice.patch506 bytesAngry Dan

Comments

Status: Needs review » Needs work

The last submitted patch, nodequeue-use-parents-notice.patch, failed testing.

danepowell’s picture

danepowell commented
Status: Needs work » Needs review
StatusFileSize
new nodequeue-2386261-2.patch844 bytes

I'm not sure why that patch didn't apply... it looks the same as this one, but maybe there's something subtle I'm missing.

danepowell’s picture

danepowell commented
Version: 7.x-2.0-alpha2 » 7.x-2.x-dev

Ah maybe it needs to be against 7.x-2.x-dev

  • fizk committed 7e7a0dc on 7.x-2.x authored by Dane Powell 
    Issue #2386261 by Dane Powell, Angry Dan: Notice use_parents is not...
fizk’s picture

fizk commented
Assigned: Angry Dan » Unassigned
Status: Needs review » Fixed

Committed, thanks!

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.