Come together with the global Drupal community in Rotterdam, 28 Sept – 1 Oct 2026. Sessions, contribution, connection, and Early Bird savings until 8 June.I'm told you're a bit busy, so I'm volunteering to upgrade nodequeue to 6.0, if that's not a problem.
| Comment | File | Size | Author |
|---|---|---|---|
| #16 | nodequeue_d6_20080512.patch | 104.77 KB | jcfiala |
| #15 | nodequeue.tar_.gz | 48.28 KB | jcfiala |
| #14 | smartqueue.module.gz | 2.3 KB | jcfiala |
| #7 | nodequeue.tar_.gz | 48.28 KB | jcfiala |
| #6 | nodequeue_d6_partial.patch | 90.1 KB | jcfiala |
Comments
Comment #1
merlinofchaos commentedIt's not, but we're not quite at a 2.0 release for Drupal 5. There's at least one thing that has to be fixed before I can do a full release, and it may not be in the issue queue. I'll ping you on IRC about it.
Comment #2
alippai commented2.0 is out. Is the update for D6 in progress?
Comment #3
merlinofchaos commentedIt likely has been on hold since jcfiala has been at Drupalcon.
Comment #4
jcfiala commentedThe update for D6 is in progress, yes!
But it's slow. There's a lot of things to change in nodequeue to make it work with D6, and there's more things to work on with the revision of actions into core, and of course there's views support...
It's going along, but it's just going to take time.
Comment #5
merlinofchaos commentedCould you post patches as you go? Once you get to a stopping point you could roll a patch of your current work. That could make it possible for others to collaborate if they wish -- in testing what you've got, expanding on areas you aren't immediately working on, or whatever.
Comment #6
jcfiala commentedThat's a good idea - sorry, I'm not entirely up to date on how to use drupal.org effectively, so I'd missed your post. I wish I could get it to email me when things change.
I'm not entirely sure I'm using diff properly here, so I'm including both the patch file and the tar.gz of my current work.
Here's what I've got done:
Nodequeue basic seems to work fine - I've played around with it a bit. I've got a couple of TODO notes in the install file for a few postgres items that I wasn't entirely sure how to handle. Your input would be good for that, I think. This is only a functionality upgrade to D6 - I haven't really tried to fold in any of the new functionality. For one, it seems like the new drag/drop capabilities of D6 would be a natural for the nodequeue list pages, where you're showing all of the items in order.
I haven't even touched smartqueue or nodequeue_generate yet.
Comment #7
jcfiala commentedHappily, I now seem to have both smartqueue and nodequeue_generate working for D6. Quick and dirty tarball coming up, as I'm a little out of it.
Need to talk to you about how multiple taxonomies work together in smartqueue - I'm not able to tell yet whether or not the weird results I'm getting are intended or not!
Comment #8
naheemsays commentedYour patch seems to be the wrong way around.
If you are using diff on a commandline (such as cygwin):
diff -upN olddirectory newdirectory > patch
Comment #9
jcfiala commentedQuite possibly.
I'm not using diff directly, I'm using it via svn. That said, given that it's effectively a rewrite from scratch, at the moment I'm just working on delivering tarballs of the updated code.
Comment #10
ogi commentedsubscribe
Comment #11
catchThis is enough of a patch to be marked as such.
Comment #12
designerbrent commentedsubscribe
Comment #13
rmiddle commentedSubscribe
Comment #14
jcfiala commentedHere's a slight change to smartqueue.module - this one file change fixes a problem with having a smartqueue across more than one taxonomy. If you had Vocabulary A and B, and a smartqueue across both of them, then you would be offered links to add a node with a term from A and B to all of SmartQueue a+b, smartqueue a, or smartqueue b.
Oh, and if anyone's working with this conversion of nodequeue and finds any problems, please do bring them up by posting them.
Comment #15
jcfiala commentedAnd since I've realized I'd done other changes - mostly to changing the nodequeue generator, I'm going to post the tarball I'm working with.
I think, since views has hit beta, I should spend some time seeing how to re-integrate nodequeue with views.
Comment #16
jcfiala commentedAnd now, I've had help creating a patch off of cvs, so this should be 5x5.
Comment #17
aqua_linksunten commentedThe integration into views is not yet working? Or am I doing something wrong?
Comment #18
catch@aqua_linksunten: please see #15
Comment #19
fletchgqc commentedFrom the comments it sounds as if you've got some functionality going. I'm not too familiar with the Drupal release process, but can you post your code as 6.x dev releases?
Comment #20
merlinofchaos commentedCommitted to HEAD so that people can begin testing or other work on this. I did absolutely 0 testing and honestly only a minimal review, but figured that it kind of sucks that nothing is happening here.
Comment #21
william haller commentedI'm going to be out of the office today so won't have a chance to do any debugging myself, but this was the 5201 upgrade results.
user warning: You have an error in your SQL syntax; check the manual that corresponds to your MySQL server version for the right syntax to use near 'Array' at line 1 query: ALTER TABLE nodequeue_queue ADD owner Array in /u/drupalweb/update.php on line 69.
user warning: You have an error in your SQL syntax; check the manual that corresponds to your MySQL server version for the right syntax to use near 'Array' at line 1 query: ALTER TABLE nodequeue_queue ADD show_in_ui Array in /u/drupalweb/update.php on line 69.
user warning: You have an error in your SQL syntax; check the manual that corresponds to your MySQL server version for the right syntax to use near 'Array' at line 1 query: ALTER TABLE nodequeue_queue ADD show_in_tab Array in /u/drupalweb/update.php on line 69.
user warning: You have an error in your SQL syntax; check the manual that corresponds to your MySQL server version for the right syntax to use near 'Array' at line 1 query: ALTER TABLE nodequeue_queue ADD show_in_links Array in /u/drupalweb/update.php on line 69.
user warning: You have an error in your SQL syntax; check the manual that corresponds to your MySQL server version for the right syntax to use near 'Array' at line 1 query: ALTER TABLE nodequeue_queue ADD reference Array in /u/drupalweb/update.php on line 69.
user warning: Unknown column 'owner' in 'field list' query: UPDATE nodequeue_queue SET owner = 'nodequeue', show_in_ui = 1, show_in_tab = 1, show_in_links = 1, reference = 0 in /u/drupalweb/sites/all/modules/nodequeue/nodequeue.install on line 269.
warning: Missing argument 1 for legal_menu() in /u/drupalweb/sites/all/modules/legal/legal.module on line 28.
It also complains about one of the modules not being compatible with 6.2
Comment #22
Luca O commentedTry to re-download the module (maybe a mistake of the mantainer?), works, for me.
In a fresh install nodequeue seems to work, but i have to do some tests.
Comment #23
merlinofchaos commenteda problem with legal.module should probably be filed against legal.module not nodequeue.module.
Also, let's file new bugs for problems; now that a few hours have gone by there is a 6.x-dev to file them against.
Comment #24
kyle_mathews commentedsubscribe
Comment #25
merlinofchaos commentedWhy did you set this back to 'active' with just a subscribe? I hope it was just a case of crossposting.
Comment #26
kyle_mathews commentedI don't know. I must of switched the status on accident. I certainly didn't mean to change the status.
Comment #27
Anonymous (not verified) commentedAutomatically closed -- issue fixed for two weeks with no activity.