nodequeue_subqueue_position() and nodequeue_get_subqueue_position() appear to be unnecessarily duplicate functions.

Patch coming.

CommentFileSizeAuthor
#2 nodequeue-duplicate_functions-2004400-2.patch1.91 KBfizk
#1 nodequeue-duplicate_functions-2004400-1.patch1.91 KBjeffschuler

Comments

jeffschuler’s picture

jeffschuler
Location Boulder, Colorado
commented
Status: Active » Needs review
StatusFileSize
new nodequeue-duplicate_functions-2004400-1.patch1.91 KB

I left a stub in there in order to not break any modules using this function.

fizk’s picture

fizk commented
Issue summary: View changes
StatusFileSize
new nodequeue-duplicate_functions-2004400-2.patch1.91 KB

Triggering automated tests.

jenlampton’s picture

jenlampton
she / her
commented
Status: Needs review » Reviewed & tested by the community

Looks great, nice catch!

  • jenlampton committed 4cc40c7 on 7.x-2.x authored by fizk 
    Issue #2004400 by jeffschuler, fizk: nodequeue_subqueue_position() ==...
jenlampton’s picture

jenlampton
she / her
commented
Status: Reviewed & tested by the community » Fixed

Merged into 7.x-2.x

jenlampton’s picture

jenlampton
she / her
commented
Title: nodequeue_subqueue_position() == nodequeue_get_subqueue_position() » Remove unnecessary duplicate function nodequeue_subqueue_position()

Retitling this issue.

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.