Contextual links for nodequeue

subscribing (and +1-ing)

Subscribing

I've just contributed an initial version of Nodequeue Extras that does this. Give it a try and let me know about any issues you find.

Great! But I'm wondering why didn't you contribute it as a patch instead, seems like a tiny piece of code that could be added to the main codebase :)

amateescu: That's a good point. The other item in Nodequeue Extras (the new relationship handler) does its work in a fairly non-traditional way by using a placeholder argument that is leveraged to pipe criteria into the join, rather than the where clause), so I felt that one needed to be in its own module rather than sticking that hack-ish code into Nodequeue itself. I happened to already have the contextual link functionality already written up in the module, too, so decided to just run with publishing them together. It may have been a bad call. I'm happy to have any of the Nodequeue Extras functionality integrated into Nodequeue as you see fit, and would be happy to help roll patches to that end.

+1 for rolling it as a patch, but either way thanks to azinck for writing the functionality.

Patch against the current stable version (7.x-2.0-beta1)

Steps I did to create the patch:
1. git clone https://drupal.org/project/nodequeue_extras and checkout 7.x-1.x
2. Patch https://drupal.org/node/1619400 (patch # 2)
curl https://drupal.org/files/nodequeue_extras-n1619400-2.patch | git apply -
3. Patch https://drupal.org/node/1920700 Patch # 1
curl https://drupal.org/files/nodequeue_extras-refactor_nesting-1920700.patch | git apply -
4. I copied the hook alter to a suitable place in nodequeue module. I didn't copy those extra special relationships files and I removed 2 lines of code.
Maybe you might need them for special case about subqueues.
5. Added an extra checkbox to nodequeue admin settings form. (The variable with the same name was already being used in nodequeue_extras module):
[x] Show contextual links.

#7 Oops!, The attached patch has strange characters because of coloured diff settings.
This is a well-formed patch:

Patch looks good but one thing

+++ b/includes/views/nodequeue.views.inc
@@ -269,3 +269,85 @@ function nodequeue_views_data_alter(&$data) {
+        'title' => t('Edit queue: !queue_name', array('!queue_name' => $queue->title)),
...
+            'title' => t('Edit subqueue: !queue_name > !subqueue_title', array('!queue_name' => $queue->title, '!subqueue_title' => $subqueue->title)),

those names are pretty big for contextual links. i would remove the name and just leave edit queue/subqueue.
its the same behavior with block or views. it does not display the view name or block name.

besides that its ready to go imo

Thanks for the patch. I agree with #10.

I rerolled #8 with suggested changes from #10. I also added a permission check to make sure the user has access to edit queues.

thanks, works nicely for me

Looks @elvis2. Tested and it works as expected.

Works well.

Committed. Thanks!

FYI: I had to clear the cache to see the new contextual link.

FYI if you add an update script with this code it'll trigger the menus to rebuild:

function nodequeue_update_7200() {
  variable_set('menu_rebuild_needed', TRUE);
  drupal_set_message(t('The menus will now be rebuild.'));
}

@DamienMcKenna Thanks, I've committed this update script.

For anyone else having issues with this there is now a follow up patch in #2468705: Contextual link to edit queue disappears.