Closed (fixed)
Project:
Node Hierarchy
Version:
6.x-1.0
Component:
Code
Priority:
Minor
Category:
Bug report
Assigned:
Unassigned
Reporter:
Created:
15 Aug 2008 at 06:17 UTC
Updated:
28 Aug 2010 at 21:43 UTC
Jump to comment: Most recent file
Comments
Comment #1
bsdunx commentedCorrect an oversight in my patch, and backup my claim.
Drupal core does;
$ grep "'_', '-'" modules/*/*
modules/book/book.module: 'href' => "node/add/". str_replace('_', '-', $child_type),
modules/forum/forum.module: $forum_types[$type] = array('title' => t('Post new @node_type', array('@node_type' => node_get_types('name', $type))), 'href' => 'node/add/'. str_replace('_', '-', $type) .'/'. $variables['tid']);
modules/node/content_types.inc: $type_url_str = str_replace('_', '-', $type->type);
modules/node/content_types.inc: $form_state['redirect'] = 'admin/content/node-type/'. str_replace('_', '-', $type->old_type) .'/delete';
modules/node/node.module: $type_url_str = str_replace('_', '-', $type->type);
modules/translation/translation.pages.inc: $options[] = l(t('add translation'), 'node/add/'. str_replace('_', '-', $node->type), array('query' => "translation=$node->nid&language=$language->language"));
$
Comment #2
ronan commentedThanks, nice find. I'll check and apply the patch as soon as I get a chance.
r
Comment #3
bsdunx commentedSweet it's always nice to post a patch on your birthday and have it promptly reviewed by the maintainer. =p I'll see if I can find some issues in the queue to hammer out also.
Comment #4
dgorton commentedYikes - this was fixed ages ago - closing the ticket