Add Features.module integration [#1063342]

I just committed Features integration to the Drupal 6 version: http://drupal.org/cvs?commit=501020

We need to port it to Drupal 7. Patch is attached.

Comment	File	Size	Author
#5	features-integration-nodeformcols-1063342-5.patch	1.4 KB	scottrigby
#3	nodeformcols_features-1063342_3.patch	1.04 KB	langworthy
#2	nodeformcols_features_2.patch	1.04 KB	voxpelli
#1	nodeformcols_features_2.patch	1.03 KB	voxpelli
	nodeformcols_features.patch	582 bytes	voxpelli

Support from Acquia helps fund testing for Drupal Acquia logo

Comments

Comment #1

voxpelli CreditAttribution: voxpelli commented 2 March 2011 at 10:22

Version:	7.x-1.x-dev	» 6.x-1.x-dev
Status:	Patch (to be ported)	» Needs review

File	Size
nodeformcols_features_2.patch	1.03 KB

The implementation wasn't a 100% correct - here's a follow up patch to the above - both need to be applied.

Comment #2

voxpelli CreditAttribution: voxpelli commented 2 March 2011 at 12:55

File	Size
nodeformcols_features_2.patch	1.04 KB

There was a typo in the previous patch - fixed in this one.

Comment #3

langworthy CreditAttribution: langworthy commented 12 March 2011 at 02:54

File	Size
nodeformcols_features-1063342_3.patch	1.04 KB

Patch from #2 rerolled using --no-prefix flag with git diff

Comment #4

chromix CreditAttribution: chromix commented 21 June 2011 at 21:33

I'm getting the following error:

WD php: Parameter 3 to nodeformcols_features_pipe_node_alter() expected to be a reference, value given [error]
in drupal/acquia-drupal-1.2.36/includes/common.inc on line 2892.
WD php: file_put_contents(sites/all/modules/features/my_feature/my_feature.views_default.inc): [error]
failed to open stream: Permission denied in drush/includes/drush.inc on line 1164.
Created module: my_feature in sites/all/modules/features/my_feature [ok]
Parameter 3 to nodeformcols_features_pipe_node_alter() expected to be a reference, value given in [warning]
includes/common.inc on line 2892.
file_put_contents(sites/all/modules/features/my_feature/my_feature.views_default.inc): failed to [warning]
open stream: Permission denied in drush/includes/drush.inc on line 1164.

Comment #5

scottrigby

he/him

English

Brooklyn, NY

CreditAttribution: scottrigby commented 6 July 2011 at 21:02

File	Size
features-integration-nodeformcols-1063342-5.patch	1.4 KB

Why change $data to $export['features']['node']?

Also this patch drops $module_name (re #792472: Implement node type -> strongarm pipe for Features).

Maybe i'm missing why that needs to be there though?

Comment #6

voxpelli CreditAttribution: voxpelli commented 10 July 2011 at 07:43

@scottrigby: See #1078478: Multiple features and strongarm conflicts regarding $data - can you check your change against that patch as well?

Comment #7

asherry CreditAttribution: asherry at Aten Design Group commented 25 September 2019 at 16:59

Issue summary:	View changes
Status:	Needs review	» Closed (won't fix)

I'm going to close this as I'm no longer supporting this project, and it doesn't seem like the work on this was finished. Feel free to re-open if anybody is still actively working on this.