Problems with array indexes in node_access_records

something weird about that patch, I think you patched it against your own previous code

I'd prefer not to use the initialize function and just put !empty() or isset() in the right spots

it can be handled inline with a ternary statement

how about this?

or i guess technically if we're passing an empty array() into those.. they won't do anything? so we could just wrap the whole call in an if-statement

How about this change in nodeaccess_nodereference_add_grant():

   // Add the grants needed, so as not to override previous iterations.
-  if (isset($settings['view']) && $settings['view']) {
+  if (!empty($settings['view'])) {
     $grants[$key]['grant_view'] = 1;
   }
-  if (isset($settings['update']) && $settings['update']) {
+  if (!empty($settings['update'])) {
     $grants[$key]['grant_update'] = 1;
   }
-  if (isset($settings['delete']) && $settings['delete']) {
+  if (!empty($settings['delete'])) {
     $grants[$key]['grant_delete'] = 1;
   }

The error in if ($data['unused'] && isset($data['referenced'])) can be prevented in my comment-to-be in #1619636: Cumulative settings improvements and fixes.

You mean in addition to the other changes?
I presume the issue is the function call.

IMO, OP's error will not occur with the new 'minified' variable from the new version.
However, you will only get this data-structure when you change, save, change-back, save-again. Which is undoable.
Or apply the hook_N_update() function in the other issue.

If the 4th param $settings is empty that function effectively does nothing. It just sets a dummy grant with 0 for everything, which is meaningless.

Also I think your comment #2 is wrong, $data['referenced'][$operation] is always going to be there if that bit of code is run, since the iterations of the foreach are based on the keys of the array, so I won't do anything about that.

nope, this one

i've committed that, i guess we can go from there if there is a prob, till then marking as fixed