Thanks again for this great module! I'd like to request a feature -

While saving a draft without entering a node reminder, this module will insert zero into the notify_on table field. This causes any node saves to add a new entry into node reminder and thus, email the user.

Assuming no one will need a reminder immediately, we should check for the empty field and disregard. Or, to be failsafe, we can include an option to turn on/off.

What do you think?

Thanks,
Alex

Comments

fizk’s picture

Status: Active » Needs review
StatusFileSize
new1.07 KB

This sounds like a good to have feature.

It seems like there's an "active" field that's not being used. Here's a patch that detects an empty amount of time and set's the active field accordingly. Let me know if the patch works for you.

mralexho’s picture

StatusFileSize
new1.71 KB

Thanks fizk.

Your patch works great, however, I was thinking of a different approach. If $reminder->amount_of_time is empty or 0, we should omit writing to the database since that will save an extra call. If $reminder->current exists and $reminder->amount_of_time equals 0, we should remove the reminder.

I also updated the .install file so notify_on is NOT NULL.

What do you think?

Alex

fizk’s picture

Status: Needs review » Reviewed & tested by the community

I think people might want to send a reminder immediately for some reason, so we shouldn't block that functionality.

fizk’s picture

Sorry mralexho, my last comment contradicts my patch :) I'll take a second look at this.

fizk’s picture

Status: Reviewed & tested by the community » Needs review
StatusFileSize
new3.38 KB

I gave this some thought and it's possible that people might have reminder notes that they wouldn't want deleted just because the amount of time field was zero, or even empty.

Here's a patch that adds a "Enabled" checkbox. The nice thing about this is that it opens us up for adding multiple reminder notifications to one node (in a future patch), where you'd want to be able to enable/disable certain reminders.

fizk’s picture

StatusFileSize
new4.68 KB

This patch also displays the reminder's enabled/disabled status in the vertical tab summary.

fizk’s picture

Version: 7.x-1.1 » 7.x-1.x-dev
fizk’s picture

Status: Fixed » Closed (fixed)

Automatically closed -- issue fixed for 2 weeks with no activity.