Closed (fixed)
Project:
Node Reminder
Version:
7.x-1.x-dev
Component:
Code
Priority:
Normal
Category:
Feature request
Assigned:
Unassigned
Reporter:
Created:
2 Jul 2013 at 17:24 UTC
Updated:
28 Jul 2013 at 18:51 UTC
Jump to comment: Most recent file
Comments
Comment #1
fizk commentedThis sounds like a good to have feature.
It seems like there's an "active" field that's not being used. Here's a patch that detects an empty amount of time and set's the active field accordingly. Let me know if the patch works for you.
Comment #2
mralexho commentedThanks fizk.
Your patch works great, however, I was thinking of a different approach. If
$reminder->amount_of_timeis empty or 0, we should omit writing to the database since that will save an extra call. If$reminder->currentexists and$reminder->amount_of_timeequals 0, we should remove the reminder.I also updated the .install file so
notify_onis NOT NULL.What do you think?
Alex
Comment #3
fizk commentedI think people might want to send a reminder immediately for some reason, so we shouldn't block that functionality.
Comment #4
fizk commentedSorry mralexho, my last comment contradicts my patch :) I'll take a second look at this.
Comment #5
fizk commentedI gave this some thought and it's possible that people might have reminder notes that they wouldn't want deleted just because the amount of time field was zero, or even empty.
Here's a patch that adds a "Enabled" checkbox. The nice thing about this is that it opens us up for adding multiple reminder notifications to one node (in a future patch), where you'd want to be able to enable/disable certain reminders.
Comment #6
fizk commentedThis patch also displays the reminder's enabled/disabled status in the vertical tab summary.
Comment #7
fizk commentedComment #8
fizk commentedCommitted!
http://drupalcode.org/project/node_reminder.git/commit/eac65c8ea1fb7dd22...