As discussed about text, words, grammar and related items in the module.
Please review, comment, hack, complain and advise.. lol, hope that covers it.
I do not know about the install patch if it can be used due to upgrade purposes, but it would be nice to have.
Still have some stuff to test and figure out on the views.inc patch.. will work on that tonight and tomorrow.
The others are basically a rewrite of the user interface text.
| Comment | File | Size | Author |
|---|---|---|---|
| #3 | theme.inc_.txt | 6.44 KB | dbeall |
| #3 | node_gallery.views_.inc_.txt | 4.15 KB | dbeall |
| #3 | node_gallery.pages_.inc_.txt | 20.62 KB | dbeall |
| #3 | node_gallery.admin_.inc_.txt | 25.7 KB | dbeall |
| #2 | node_gallery.admin_.inc2_.patch | 16.29 KB | dbeall |
Comments
Comment #1
dbeall commentedchange status
Comment #2
dbeall commentedFound a flaw in this patch, re-submit. some kind of word wrap caused it. @@ -170,15 +170,15 @@
Comment #3
dbeall commentedIf anyone wants to look at these to see what you think ! without patching files !
Applying patches to files is really a pain in the (you know what).
Creating a patch is easy, but applying them is surgery for geeks..
Here is the full files with my changes included.
Remove the underscore _.inc and remove( _.txt ), and stick them in your node_gallery dev.
Comment #4
kmontyNot really sure what to do here:
- $empty_message .= ' '. l('Upload Some!', 'node/'. $gallery->nid .'/upload', array('query' => 'destination=node/'. $gallery->nid));
+ $empty_message .= ' '. l('click here to upload some images!', 'node/'. $gallery->nid .'/upload', array('query' => 'destination=node/'. $gallery->nid));
I don't want to use the words "click here" because there is 1990's web speak... in general, people know that the action to take on a link is to click it. That said, I admit "Upload some!" is lame. Not sure what the best phase is.
Maybe "You may upload images to this gallery."
Comment #5
dbeall commentedI will have a look and come up with something.. I wasn't too sure about that one either.
--I have people using sites that still need the click me stuff, I know..lol, Please get with it.--
I don't think Upload some was lame, just maybe something a little better...
I'll be back, see if anything else is not right.
Oh, one other thing I noticed in the install file,
The 'Image Gallery' and 'Gallery Image' might be confusing when looking at the relationship setting, but they don't need configured on a default install, just being picky.
Maybe name it 'Photo Gallery'.
Comment #6
dbeall commentedHow about:
There are no images in this gallery, upload some images!
There are no images in this gallery, now you can upload some images!
There are no images in this gallery, upload your images!
There are no images in this gallery, add your images!
There are no images in this gallery, you can add images now!
There are no images in this gallery, add some images!
ideas???
Comment #7
kmontyI also kept most of the standard file upload default text, as it is the same text used by drupal core.
Comment #8
dbeall commentedThats ok, people can change that to plain English easy enough. I used the term images so people won't think they can use any old file, it needs to be an image.
Some Drupal core language is off as well, such as tracker(nobody knows what that is). I have a list of Drupal terms that I have to change in core with every upgrade.
Comment #9
kmontyThe changes to the install file:
- 'name' => t('Gallery'),
+ 'name' => t('Image Gallery'),
- 'description' => t('This is a gallery (album). This will be the parent of your individual images.'),
+ 'description' => t('This will create an image gallery or album. The image gallery will control the uploading, editing and display of the images. Your image gallery requires a name upon creation and a description is optional. After you have completed the first step, images can be added to the gallery.'),
I am not sure how I feel about these changes. I definitely don't think we should change 'Gallery' to 'Image Gallery' as that might confuse people as to what is the gallery node and what is the gallery image node. I'm also wondering how much instruction we need in the gallery description. In general, default drupal content type descriptions do not provide that level of detail. I'm not sure we need to either.
Comment #10
dbeall commentedwell, if you look at page or story, they have about the same amount of text.
Comment #11
dbeall commentedmaybe just keep the first part:
This will create an image gallery or album. The image gallery will control the uploading, editing and display of the images.
Comment #12
kmontyI committed all the changes aside from the lines I commented on above.
Comment #13
dbeall commentedsounds good, glad I could help
Comment #14
dbeall commentedComment #15
kmontyAbsolutely stoked you could help on this one. It was a major undertaking to clean up the grammar :-)