Fix Drupal CI issues on PHP >= 5.4 [#2634104]

Comment	File	Size	Author
#19	new_relic_insights-fix_tests_on_php_54_up-2634104-18-DO_NOT_COMMIT.patch	823 bytes	iamEAP
#19	7.x-1.x: PHP 5.3 & MySQL 5.5, D7 64 pass PHP 5.4 & MySQL 5.5, D7 63 pass, 1 fail PHP 5.5 & MySQL 5.5, D7 64 pass PHP 5.6 & MySQL 5.5, D7 64 pass
#18	new_relic_insights-fix_tests_on_php_54_up-2634104-18-DO_NOT_COMMIT.patch	823 bytes	iamEAP
#18
#16	new_relic_insights-fix_tests_on_php_54_up-2634104-16.patch	629 bytes	iamEAP
#16	7.x-1.x: PHP 5.3 & MySQL 5.5, D7 64 pass PHP 5.4 & MySQL 5.5, D7 63 pass, 1 fail PHP 5.5 & MySQL 5.5, D7 64 pass PHP 5.6 & MySQL 5.5, D7 64 pass
#12	new_relic_insights-fix_tests_on_php_54_up-2634104-12.patch	633 bytes	iamEAP
#12	7.x-1.x: PHP 5.3 & MySQL 5.5, D7 64 pass PHP 5.4 & MySQL 5.5, D7 63 pass, 1 fail PHP 5.5 & MySQL 5.5, D7 63 pass, 1 fail PHP 5.6 & MySQL 5.5, D7 63 pass, 1 fail
#8	new_relic_insights-fix_tests_on_php_54_up-2634104-6.patch	595 bytes	iamEAP
#8	7.x-1.x: PHP 5.3 & MySQL 5.5, D7 64 pass PHP 5.4 & MySQL 5.5, D7 63 pass, 1 fail PHP 5.5 & MySQL 5.5, D7 63 pass, 1 fail PHP 5.6 & MySQL 5.5, D7 63 pass, 1 fail
#6	new_relic_insights-fix_tests_on_php_54_up-2634104-6.patch	595 bytes	iamEAP
#6
#2	new_relic_insights-fix_tests_on_php_54_up-2634104-2.patch	861 bytes	iamEAP
#2	7.x-1.x: PHP 5.3 & MySQL 5.5, D7 64 pass PHP 5.4 & MySQL 5.5, D7 63 pass, 1 fail PHP 5.5 & MySQL 5.5, D7 63 pass, 1 fail PHP 5.6 & MySQL 5.5, D7 63 pass, 1 fail

Support from Acquia helps fund testing for Drupal Acquia logo

Comments

Comment #1

13 December 2015 at 05:53

iamEAP created an issue. See original summary.

Comment #2

iamEAP CreditAttribution: iamEAP commented 13 December 2015 at 05:57

Status:

Active

» Needs review

File	Size
new_relic_insights-fix_tests_on_php_54_up-2634104-2.patch	861 bytes
7.x-1.x: PHP 5.3 & MySQL 5.5, D7 64 pass PHP 5.4 & MySQL 5.5, D7 63 pass, 1 fail PHP 5.5 & MySQL 5.5, D7 63 pass, 1 fail PHP 5.6 & MySQL 5.5, D7 63 pass, 1 fail

Not actually breaking functionality, just bad test expectations / naughty casting.

Comment #3

13 December 2015 at 06:00

Status:

Needs review

» Needs work

The last submitted patch, 2: new_relic_insights-fix_tests_on_php_54_up-2634104-2.patch, failed testing.

Comment #4

13 December 2015 at 06:00

The last submitted patch, 2: new_relic_insights-fix_tests_on_php_54_up-2634104-2.patch, failed testing.

Comment #5

13 December 2015 at 06:00

The last submitted patch, 2: new_relic_insights-fix_tests_on_php_54_up-2634104-2.patch, failed testing.

Comment #6

iamEAP CreditAttribution: iamEAP commented 13 December 2015 at 06:09

File	Size
new_relic_insights-fix_tests_on_php_54_up-2634104-6.patch	595 bytes

Trying another approach...

Comment #7

iamEAP CreditAttribution: iamEAP commented 13 December 2015 at 06:06

Status:

Needs work

» Needs review

Comment #8

iamEAP CreditAttribution: iamEAP commented 13 December 2015 at 06:12

File	Size
new_relic_insights-fix_tests_on_php_54_up-2634104-6.patch	595 bytes
7.x-1.x: PHP 5.3 & MySQL 5.5, D7 64 pass PHP 5.4 & MySQL 5.5, D7 63 pass, 1 fail PHP 5.5 & MySQL 5.5, D7 63 pass, 1 fail PHP 5.6 & MySQL 5.5, D7 63 pass, 1 fail

1 file was hidden/shown/deleted

File	Size
new_relic_insights-fix_tests_on_php_54_up-2634104-2.patch	861 bytes
7.x-1.x: PHP 5.3 & MySQL 5.5, D7 64 pass PHP 5.4 & MySQL 5.5, D7 63 pass, 1 fail PHP 5.5 & MySQL 5.5, D7 63 pass, 1 fail PHP 5.6 & MySQL 5.5, D7 63 pass, 1 fail

Hmm... Apparently Drupal CI doesn't test new patches while the issue is set to "needs work" unless you explicitly set it to "needs review" on the comment that includes the patch?

Comment #9

13 December 2015 at 06:14

Status:

Needs review

» Needs work

The last submitted patch, 8: new_relic_insights-fix_tests_on_php_54_up-2634104-6.patch, failed testing.

Comment #10

13 December 2015 at 06:14

The last submitted patch, 8: new_relic_insights-fix_tests_on_php_54_up-2634104-6.patch, failed testing.

Comment #11

13 December 2015 at 06:14

The last submitted patch, 8: new_relic_insights-fix_tests_on_php_54_up-2634104-6.patch, failed testing.

Comment #12

iamEAP CreditAttribution: iamEAP commented 13 December 2015 at 06:26

Status:

Needs work

» Needs review

File	Size
new_relic_insights-fix_tests_on_php_54_up-2634104-12.patch	633 bytes
7.x-1.x: PHP 5.3 & MySQL 5.5, D7 64 pass PHP 5.4 & MySQL 5.5, D7 63 pass, 1 fail PHP 5.5 & MySQL 5.5, D7 63 pass, 1 fail PHP 5.6 & MySQL 5.5, D7 63 pass, 1 fail

1 file was hidden/shown/deleted

File	Size
new_relic_insights-fix_tests_on_php_54_up-2634104-6.patch	595 bytes
7.x-1.x: PHP 5.3 & MySQL 5.5, D7 64 pass PHP 5.4 & MySQL 5.5, D7 63 pass, 1 fail PHP 5.5 & MySQL 5.5, D7 63 pass, 1 fail PHP 5.6 & MySQL 5.5, D7 63 pass, 1 fail

Comment #13

13 December 2015 at 06:33

Status:

Needs review

» Needs work

The last submitted patch, 12: new_relic_insights-fix_tests_on_php_54_up-2634104-12.patch, failed testing.

Comment #14

13 December 2015 at 06:34

The last submitted patch, 12: new_relic_insights-fix_tests_on_php_54_up-2634104-12.patch, failed testing.

Comment #15

13 December 2015 at 06:34

The last submitted patch, 12: new_relic_insights-fix_tests_on_php_54_up-2634104-12.patch, failed testing.

Comment #16

iamEAP CreditAttribution: iamEAP commented 13 December 2015 at 06:55

Status:

Needs work

» Needs review

File	Size
new_relic_insights-fix_tests_on_php_54_up-2634104-16.patch	629 bytes
7.x-1.x: PHP 5.3 & MySQL 5.5, D7 64 pass PHP 5.4 & MySQL 5.5, D7 63 pass, 1 fail PHP 5.5 & MySQL 5.5, D7 64 pass PHP 5.6 & MySQL 5.5, D7 64 pass

1 file was hidden/shown/deleted

File	Size
new_relic_insights-fix_tests_on_php_54_up-2634104-12.patch	633 bytes
7.x-1.x: PHP 5.3 & MySQL 5.5, D7 64 pass PHP 5.4 & MySQL 5.5, D7 63 pass, 1 fail PHP 5.5 & MySQL 5.5, D7 63 pass, 1 fail PHP 5.6 & MySQL 5.5, D7 63 pass, 1 fail

...

Comment #17

13 December 2015 at 06:58

Status:

Needs review

» Needs work

The last submitted patch, 16: new_relic_insights-fix_tests_on_php_54_up-2634104-16.patch, failed testing.

Comment #18

iamEAP CreditAttribution: iamEAP commented 13 December 2015 at 07:03

Status:

Needs work

» Needs review

File	Size
new_relic_insights-fix_tests_on_php_54_up-2634104-18-DO_NOT_COMMIT.patch	823 bytes

1 file was hidden/shown/deleted

File	Size
new_relic_insights-fix_tests_on_php_54_up-2634104-16.patch	629 bytes
7.x-1.x: PHP 5.3 & MySQL 5.5, D7 64 pass PHP 5.4 & MySQL 5.5, D7 63 pass, 1 fail PHP 5.5 & MySQL 5.5, D7 64 pass PHP 5.6 & MySQL 5.5, D7 64 pass

Completely deleting offending code... Debugging Drupal CI...

Comment #19

iamEAP CreditAttribution: iamEAP commented 13 December 2015 at 07:06

File	Size
new_relic_insights-fix_tests_on_php_54_up-2634104-18-DO_NOT_COMMIT.patch	823 bytes
7.x-1.x: PHP 5.3 & MySQL 5.5, D7 64 pass PHP 5.4 & MySQL 5.5, D7 63 pass, 1 fail PHP 5.5 & MySQL 5.5, D7 64 pass PHP 5.6 & MySQL 5.5, D7 64 pass

Apparently Drupal CI will not test patches that are marked as not-to-be-displayed on creation?

Comment #20

13 December 2015 at 07:11

Status:

Needs review

» Needs work

The last submitted patch, 19: new_relic_insights-fix_tests_on_php_54_up-2634104-18-DO_NOT_COMMIT.patch, failed testing.

Comment #21

14 December 2015 at 22:57

iamEAP authored 4859ecb on 7.x-1.x

Issue #2634104 by iamEAP: Fix Drupal CI issues on PHP >= 5.4

Comment #22

iamEAP CreditAttribution: iamEAP commented 14 December 2015 at 23:06

Status:

Needs work

» Fixed

Just committed the patch I know was right (#2). All patches and comments after #2 are a result of a Drupal CI issue. Bug opened up for that here: https://www.drupal.org/node/2634114