Separate unaggregated results method

1. +++ b/src/Plugin/monitoring/SensorPlugin/DatabaseAggregatorSensorPlugin.php
   @@ -160,6 +160,14 @@ class DatabaseAggregatorSensorPlugin extends DatabaseAggregatorSensorPluginBase
   +   * {@inheritdoc}
   ...
   +  public function verboseResultUnaggregated(array &$output) {
   

   And inherited from what? :-)

2. +++ b/src/Plugin/monitoring/SensorPlugin/WatchdogAggregatorSensorPlugin.php
   @@ -0,0 +1,84 @@
   +    unset($form['table']);
   

   Are you sure saving the sensor does not lead to deleting the verbose fields?

2. Still my question: Is the field accidentally emptied when saving (other sensor configuration)? Because it might be needed that you set this a hidden item or just access false instead.

Interdiff? :-)

At the same time you now introduce the watchdog plugin. If we are going to do this, then please also update all default configuration for watchdog table sensors to use the new sensor plugin.

Rest looks fine.

+++ b/src/Plugin/monitoring/SensorPlugin/WatchdogAggregatorSensorPlugin.php
@@ -0,0 +1,85 @@
+    $form['table']['#disabled'] = TRUE;

Add a comment why we hide it.

Finally, i think, for the new Watchdog behaviour we really need a tests.

You are deleting multiple files. Why? .-)

+++ b/config/install/monitoring.sensor_config.user_failed_logins.yml
@@ -2,7 +2,7 @@ id: user_failed_logins
-plugin_id: user_failed_logins

+++ b/config/optional/monitoring.sensor_config.dblog_404.yml
@@ -7,7 +7,7 @@ id: dblog_404
-plugin_id: dblog_404
+plugin_id: watchdog_aggregator

Really switch them to the currentl watchdog sensor? Is the new watchdog sensor providing everything

just have custom messages

Because we want NICE messages. That's the whole point of monitoring.
Fine if you want to subclass the watchdog sensor in case it makes sense. Dunno. Can be a followup.

1. +++ b/src/Plugin/monitoring/SensorPlugin/DatabaseAggregatorSensorPlugin.php
   @@ -160,6 +160,14 @@ class DatabaseAggregatorSensorPlugin extends DatabaseAggregatorSensorPluginBase
   +    $this->verboseResultUnaggregated($output);
   
   +++ b/src/SensorPlugin/DatabaseAggregatorSensorPluginBase.php
   @@ -124,6 +124,15 @@ abstract class DatabaseAggregatorSensorPluginBase extends SensorPluginBase {
   +  public function verboseResultUnaggregated(array &$output) {
   

   Hm, The DatabaseAggregatorSensorPluginBase is not really an interface definition. It provides default implementations for database aggregators. By adding a stub here, we won't gain anything. Just add it on DatabaseAggregatorSensorPlugin and move it up once there is a common part... If anything it would be extending the Interface where resultVerbose originates (ExtendedInfoSensorPluginInterface) but that's a different story. For now we shouls just improve again and again our verbose outputs until we know how to better define an "extended info" interface. ;-)

2. +++ b/src/Plugin/monitoring/SensorPlugin/WatchdogAggregatorSensorPlugin.php
   @@ -0,0 +1,86 @@
   + * Simple database aggregator able to query a single db table.
   

   Try harder.

3. +++ b/src/Plugin/monitoring/SensorPlugin/WatchdogAggregatorSensorPlugin.php
   @@ -0,0 +1,86 @@
   +    foreach ($query_result as $record) {
   ...
   +      if (array_key_exists('message', $row)) {
   +        if (array_key_exists('variables', $row)) {
   +          $row['message'] = SafeMarkup::format($row['message'], unserialize($row['variables']));
   +          unset($row['variables']);
   

   You could just call parent verboseResultUnaggregated() and then alter the rows in 'result'. You repeat too much code.

4. +++ b/src/SensorPlugin/DatabaseAggregatorSensorPluginBase.php
   @@ -124,6 +124,15 @@ abstract class DatabaseAggregatorSensorPluginBase extends SensorPluginBase {
   +   * Adds verbose result to the render array $output.
   

   Missing "unaggregated". Too much copy paste.

5. +++ b/src/Tests/MonitoringCoreWebTest.php
   @@ -26,6 +26,43 @@ class MonitoringCoreWebTest extends MonitoringTestBase {
   +   * Tests active session count through db aggregator sensor.
   

   Active session count?

Plz pull / rebase...

+++ b/src/Plugin/monitoring/SensorPlugin/WatchdogAggregatorSensorPlugin.php
@@ -0,0 +1,61 @@
+ * More specific database aggregator for querying the watchdog table.
...
+ *   description = @Translation("Simple aggregator able to query the watchdog table."),

Those are summaries. Be specific in what specificity is provided or don't mention it. You might want to mention the variable handling.

EDIT: Discussed, reviewed...

Looks good, but providing some cleanup. Hope it passes then i can commit.

Yay! committed.