Sensor for php notices

Here is a patch that provides the sensor. Ordering is broken, but that's a general DatabaseAggregatorSensorPlugin problem.

This is mostly duplicate code from Watchdog issue.

Either postpone this issue immediately and wait for the Watchdog plugin... Or just reduce this issue to just provide default sensor configuration for the database aggregator sensor.. (and later switch to the Watchdog sensor.)

Postponed until watchdog sensor is committed (some code from here should be implemented over there, the replacement is more functional in this version). #2525426: Separate unaggregated results method

Unpostponing since we have now the Watchdog aggregator.

Here is the sensor. It still has a custom SensorPlugin (because the sensor message is kind of custom) but it extends the watchdog sensor. Also has a test.

Somehow added the runSesnsor() to the watchdog aggregator as well, unneeded.

Interdiff for the removal.

Alright, here is the latest version. Looks rather good, but actually doesn't work as intended yet.

Problems:

• The results are still not sorted by record_count (the entry with the most occurrences should be at the top)
• The width of each column seems rather arbitrary (important columns squeezed together, 'useless' column takes up most space)

I had to go through some hoops to get it working (making slight changes to the parent class WatchdogAggregatorSensorPlugin), so some review before continuing would be useful. The default value for table and aggregation are definitely missing at the moment (creating a new watchdog sensor via UI is impossible).
By the way, I haven't changed the test yet, I don't expect it to pass (if it does, yay! :D).

Screenshot of the verbose result (and the query):

Yeah that's a common problem with tables and fine as a starting point.

We can consider an alternative table display (like responsive table that does a vertical display) but that's a different issue.

+++ b/src/Plugin/monitoring/SensorPlugin/PhpNoticesSensorPlugin.php
@@ -0,0 +1,105 @@
+  public function verboseResultUnaggregated(array &$output) {
...
+  public function resultVerbose(SensorResultInterface $result) {
...
+    $this->verboseResultUnaggregated($output);

Huh... No the Unaggregated is already called in DatabaseAggregatorSensorPlugin::verboseResult().
Don't call it a second time.

Other than tht, didn't check in much detail.

Ordering works now, removed the unnecessary call to unaggregatedResultVerbose.

Fixed the test fails.

(Moved the sensor to optional because of dblog dependency)
(updated tests with new sensor message)

Berdir 2.) "Monitors and displays the " sounds like a lot redundancy?

5. XssFilter is exactly what we needed to add since the usa if "!" makes it mark the contant as unsafe and everything is escaped afterwards...

10. Monitoring has this problem with providing more specific sensors that things are configurable (from a base sensor) but should not be editable anymore... That's only one particular case. This problem is mostly unresolved in the UI yet. In this particular case i would expect that a time interval of 0 is like not applying a time interval...

11. I would prefer to have a table with individual columns:
- Type
- Date
- File
- Line
- Message
And yeah, please check the verbose output based on some real data, including the double encoding problem above (5).

Here is the latest version, now with a count for each row and a generally better table building structure in DatabaseAggregatorSensorPlugin. The watchdog aggregator still works as usual.

The test for the dblog_php_notices sensor was not updated, the other exception will be gone when issue #2525432: Separate text fields per verbose extra field is committed.

When I apply the patch (#23) I get:
"Warning: implode(): Invalid arguments passed in Drupal\monitoring\Plugin\monitoring\SensorPlugin\DatabaseAggregatorSensorPlugin->buildConfigurationForm() (line 309 of /usr/local/var/www/d8.dev/www/modules/monitoring/src/Plugin/monitoring/SensorPlugin/DatabaseAggregatorSensorPlugin.php).".

Is it because #2525432: Separate text fields per verbose extra field is not committed yet?

1. +++ b/src/Plugin/monitoring/SensorPlugin/DatabaseAggregatorSensorPlugin.php
   @@ -171,40 +171,51 @@ class DatabaseAggregatorSensorPlugin extends DatabaseAggregatorSensorPluginBase
   +   *   The $rows for which a header should be built.
   

   $rows => rows

2. +++ b/src/Plugin/monitoring/SensorPlugin/PhpNoticesSensorPlugin.php
   @@ -0,0 +1,118 @@
   +class PhpNoticesSensorPlugin extends WatchdogAggregatorSensorPlugin {
   +  /**
   

   A blank line here?

I amended the comment so the $ is gone and it's more explanatory.

Also added the new line, didn't know that, thanks!

Yes, the exception will be gone when #2525432: Separate text fields per verbose extra field is committed, the imploding/exploding is only done because of the text area to enter keys/verbose_fields (the new name) and causes some problems if the input NULL.

+++ b/src/Plugin/monitoring/SensorPlugin/PhpNoticesSensorPlugin.php
@@ -0,0 +1,119 @@
+ */
+
+class PhpNoticesSensorPlugin extends WatchdogAggregatorSensorPlugin {
+  /**

Oh, I thought a blank line between class and method doc comment.

Fixed some test fails for the Kernel test, moved the $this->verboseResultUnaggregated($output); call. (The output was completely missing, this fixes that) and added test coverage for the verbose output in the WebTest.

Couldn't reproduce the error after moving the unaggregatedResultVerbose method call anymore...

The foreach exception we saw once is easily fixed by removing the fields validation from the validation method. Since we can't configure the fields for the output, validating them is wrong anyway. The previous test failed with my xpath queries, so I left the debug in this path to take a look.

Readded validation + a stub method for PHP sensor.

Last version, if the xpath still fails, I'll have to find another solution.

Also fixed some more exceptions/error which resulted from parent methods validating/expecting fields/conditions which aren't used for the php sensor.

Uhhm, ignore the patch above.

Added debugs for the two arrays that are compared, locally the test passes, so 'm kind of debugging the testbot.

I think this one should pass local tests and the testbot's test, I changed the logged error message's file path to use DRUPAL_ROOT as well, so the test works locally and on the testbot and the filename shortening is tested. I also changed one test to only assert the existence of a variable, instead of checking the value as well. The count changed with every minor change and the assert was not meant for that anyway.

Let's backport this.

Early patch, still didn't find the FormatableMarkup d7 replace. Also mixed the verboseResultUnaggregated method appending the other ones in one single method.

Changed a bit, fixed those FormattableMarkup thingys. Also added it to be listed on the sensors page.

New patch, now should work better, still working on tests.