I've installed Drupal 8.4.0-alpha1 and tried to install Module Filter 8.x-3.0. After enabling it, I've noticed that the module does not work at all. Then, I've tried to install Module Filter 8.x-3.x-dev, run a db update and cleared the cache. Unfortunately, nothing has changed.

CommentFileSizeAuthor
#4 filtering-tabs-doesnt-work-2902019-4.patch535 bytesalphawebgroup

Comments

Orkut Murat Yılmaz created an issue. See original summary.

alison’s picture

alison
she/her
commented

Issue still happening in 8.4.0-beta1 :(

wrd’s picture

wrd commented

I get the following javascript error with module_filter enabled. It goes away when I disable the module.

TypeError: $checkbox.size is not a function. (In '$checkbox.size()', '$checkbox.size' is undefined)

alphawebgroup’s picture

alphawebgroup
he/him
Primary language English
Location Kyiv / Toronto
commented
Status: Active » Needs review
StatusFileSize
new filtering-tabs-doesnt-work-2902019-4.patch535 bytes
joelpittet’s picture

joelpittet
he/him
Primary language English
Location Vancouver
commented
Status: Needs review » Reviewed & tested by the community

Was removed in jQuery 3, good catch.

alison’s picture

alison
she/her
commented

#4 worked perfectly for me on 8.4.0-beta1!

efpapado’s picture

efpapado commented

#4 worked perfectly for me on 8.4.0-rc1 too. Please commit!

wrd’s picture

wrd commented

#4 is working for me on 8.4.0-rc1 as well.

mogio_hh’s picture

mogio_hh commented

#4 is working for 8.4.0-rc2.

Should make it's way at least to DEV as 8.4 is rc2
Cheers

websiteworkspace’s picture

websiteworkspace commented

I can confirm experiencing this same problem with core 8.4.0.

kpaxman’s picture

kpaxman commented

I confirm that the issue exists in 8.4.0 final, and the patch in #4 fixes it. Adding my voice to the people calling for this to be added into the dev branch. Thanks!

websiteworkspace’s picture

websiteworkspace commented

The patch at #4 is working.

drupov’s picture

drupov commented

Yep, #4 works with 8.4.0

maxilein’s picture

maxilein commented

Will there be a new release for D.8.4.0 or will everybody have to patch the system?

alphawebgroup’s picture

alphawebgroup
he/him
Primary language English
Location Kyiv / Toronto
commented
Status: Reviewed & tested by the community » Fixed

looks like it's fixed now

websiteworkspace’s picture

websiteworkspace commented

A new release is available that fixes this problem and various others.

https://www.drupal.org/project/module_filter/releases/8.x-3.1

websiteworkspace’s picture

websiteworkspace commented

Another confirmation that this module is working correctly now.
The problems that existed previously with this module have been fixed with this update to 3.1.
Updated via composer, and verified that all fixes are functional.

biigniick’s picture

biigniick commented

I'm having a similar issue on Drupal 8.4 and Module Filter 3.1

I've updated Module Filter with composer, flushed caches, uninstalled, reinstalled... not sure what else to try. Any help would be awesome.

chrome console output displays this

module_filter.modules.js?v=8.4.0:55
Uncaught TypeError: $checkbox.size is not a function
    at HTMLTableRowElement.ModuleFilter.input.winnow.buildIndex (module_filter.modules.js?v=8.4.0:55)
    at HTMLTableRowElement.<anonymous> (jquery.winnow.js?v=8.4.0:217)
    at Function.each (jquery.min.js?v=3.2.1:2)
    at r.fn.init.each (jquery.min.js?v=3.2.1:2)
    at Winnow.buildIndex (jquery.winnow.js?v=8.4.0:208)
    at Winnow.filter (jquery.winnow.js?v=8.4.0:248)
    at HTMLInputElement.<anonymous> (jquery.winnow.js?v=8.4.0:112)
    at later (jquery.winnow.js?v=8.4.0:28)

with the tabs disabled by unchecking that option in config (/admin/config/user-interface/module-filter) the error doesn't show up until typing in the filter box.

with tabs enabled the error displays as soon as the tabs render in the screen.

nevermind. apparently something didn't update and clearing caches, unchecking aggregate js, and re-checking, and clearing caches again fixed it

must have been a cache issue

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.

mogio_hh’s picture

mogio_hh commented

Is this Fix by now in dev ? or stable ? How can I find out?

marty.true’s picture

marty.true commented

Please reopen this issue as it still persists. I am using Drupal 8.5.6 and Module Filter 8.x-3.x-dev (latest) and this exact issue still persists and I am getting the same javascript error as reported in #3 above.
Even after all the Drupal/Drush cache clearing, you will still need to clear your browser cache to see this working properly.