32/32 [▓▓▓▓▓▓▓▓▓▓▓▓▓▓▓▓▓▓▓▓▓▓▓▓▓▓▓▓] 100%


================================================================================
Module Builder,  8.x-3.5
Scanned on Sat, 05/23/2020 - 11:30

FILE:
web/modules/contrib/module_builder/module_builder_devel/src/Form/ProcessDevelFor
m.php

STATUS         LINE                           MESSAGE
--------------------------------------------------------------------------------
Check manually 91   Calls to function dpm should not exist.
--------------------------------------------------------------------------------

FILE:
web/modules/contrib/module_builder/module_builder_devel/src/Form/ProcessFormExtr
a.php

STATUS         LINE                           MESSAGE
--------------------------------------------------------------------------------
Check manually 35   Call to deprecated function drupal_set_message(). Deprecated
                    in drupal:8.5.0 and is removed from drupal:9.0.0. Use
                    Drupal\Core\Messenger\MessengerInterface::addMessage()
                    instead.
--------------------------------------------------------------------------------

FILE: web/modules/contrib/module_builder/src/ExceptionHandler.php

STATUS         LINE                           MESSAGE
--------------------------------------------------------------------------------
Check manually 23   Call to deprecated function drupal_set_message(). Deprecated
                    in drupal:8.5.0 and is removed from drupal:9.0.0. Use
                    Drupal\Core\Messenger\MessengerInterface::addMessage()
                    instead.
--------------------------------------------------------------------------------
Check manually 26   Call to deprecated function drupal_set_message(). Deprecated
                    in drupal:8.5.0 and is removed from drupal:9.0.0. Use
                    Drupal\Core\Messenger\MessengerInterface::addMessage()
                    instead.
--------------------------------------------------------------------------------

FILE: web/modules/contrib/module_builder/src/Form/ComponentGenerateForm.php

STATUS         LINE                           MESSAGE
--------------------------------------------------------------------------------
Check manually 40   Call to deprecated function drupal_set_message(). Deprecated
                    in drupal:8.5.0 and is removed from drupal:9.0.0. Use
                    Drupal\Core\Messenger\MessengerInterface::addMessage()
                    instead.
--------------------------------------------------------------------------------
Check manually 57   Call to deprecated function drupal_set_message(). Deprecated
                    in drupal:8.5.0 and is removed from drupal:9.0.0. Use
                    Drupal\Core\Messenger\MessengerInterface::addMessage()
                    instead.
--------------------------------------------------------------------------------
Check manually 179  Call to deprecated constant FILE_CREATE_DIRECTORY:
                    Deprecated in drupal:8.7.0 and is removed from drupal:9.0.0.
                    Use Drupal\Core\File\FileSystemInterface::CREATE_DIRECTORY.
--------------------------------------------------------------------------------
Check manually 179  Call to deprecated function file_prepare_directory().
                    Deprecated in drupal:8.7.0 and is removed from drupal:9.0.0.
                    Use
                    Drupal\Core\File\FileSystemInterface::prepareDirectory().
--------------------------------------------------------------------------------
Check manually 191  Call to deprecated function drupal_set_message(). Deprecated
                    in drupal:8.5.0 and is removed from drupal:9.0.0. Use
                    Drupal\Core\Messenger\MessengerInterface::addMessage()
                    instead.
--------------------------------------------------------------------------------
Check manually 198  Call to deprecated function drupal_set_message(). Deprecated
                    in drupal:8.5.0 and is removed from drupal:9.0.0. Use
                    Drupal\Core\Messenger\MessengerInterface::addMessage()
                    instead.
--------------------------------------------------------------------------------
Check manually 221  Call to deprecated function drupal_set_message(). Deprecated
                    in drupal:8.5.0 and is removed from drupal:9.0.0. Use
                    Drupal\Core\Messenger\MessengerInterface::addMessage()
                    instead.
--------------------------------------------------------------------------------
Check manually 278  Call to deprecated constant FILE_CREATE_DIRECTORY:
                    Deprecated in drupal:8.7.0 and is removed from drupal:9.0.0.
                    Use Drupal\Core\File\FileSystemInterface::CREATE_DIRECTORY.
--------------------------------------------------------------------------------
Check manually 278  Call to deprecated function file_prepare_directory().
                    Deprecated in drupal:8.7.0 and is removed from drupal:9.0.0.
                    Use
                    Drupal\Core\File\FileSystemInterface::prepareDirectory().
--------------------------------------------------------------------------------

FILE: web/modules/contrib/module_builder/src/Form/ComponentSectionForm.php

STATUS         LINE                           MESSAGE
--------------------------------------------------------------------------------
Check manually 110  Call to deprecated function drupal_set_message(). Deprecated
                    in drupal:8.5.0 and is removed from drupal:9.0.0. Use
                    Drupal\Core\Messenger\MessengerInterface::addMessage()
                    instead.
--------------------------------------------------------------------------------
Check manually 852  Call to deprecated function drupal_set_message(). Deprecated
                    in drupal:8.5.0 and is removed from drupal:9.0.0. Use
                    Drupal\Core\Messenger\MessengerInterface::addMessage()
                    instead.
--------------------------------------------------------------------------------
Check manually 857  Call to deprecated function drupal_set_message(). Deprecated
                    in drupal:8.5.0 and is removed from drupal:9.0.0. Use
                    Drupal\Core\Messenger\MessengerInterface::addMessage()
                    instead.
--------------------------------------------------------------------------------

FILE: web/modules/contrib/module_builder/src/Form/ModuleHooksForm.php

STATUS         LINE                           MESSAGE
--------------------------------------------------------------------------------
Fix now        96   Call to deprecated method l() of class Drupal. Deprecated in
                    drupal:8.0.0 and is removed from drupal:9.0.0. Use
                    \Drupal\Core\Link::fromTextAndUrl() instead.
--------------------------------------------------------------------------------

FILE: web/modules/contrib/module_builder/src/Form/ProcessForm.php

STATUS         LINE                           MESSAGE
--------------------------------------------------------------------------------
Check manually 55   Call to deprecated function format_date(). Deprecated in
                    drupal:8.0.0 and is removed from drupal:9.0.0. Use
                    Drupal::service('date.formatter')->format().
--------------------------------------------------------------------------------
Check manually 74   Call to deprecated function drupal_set_message(). Deprecated
                    in drupal:8.5.0 and is removed from drupal:9.0.0. Use
                    Drupal\Core\Messenger\MessengerInterface::addMessage()
                    instead.
--------------------------------------------------------------------------------
Check manually 195  Call to deprecated function drupal_set_message(). Deprecated
                    in drupal:8.5.0 and is removed from drupal:9.0.0. Use
                    Drupal\Core\Messenger\MessengerInterface::addMessage()
                    instead.
--------------------------------------------------------------------------------

FILE:
web/modules/contrib/module_builder/tests/src/Functional/ComponentFormTest.php

STATUS         LINE                           MESSAGE
--------------------------------------------------------------------------------
Check manually      Class PHPUnit\Framework\TestCase not found and could not be
                    autoloaded.
--------------------------------------------------------------------------------
Check manually 15   Class PHPUnit\Framework\TestCase not found and could not be
                    autoloaded.
--------------------------------------------------------------------------------

FILE:
web/modules/contrib/module_builder/tests/src/Unit/ComponentSectionFormHandlerTes
t.php

STATUS         LINE                           MESSAGE
--------------------------------------------------------------------------------
Check manually      Class PHPUnit\Framework\TestCase not found and could not be
                    autoloaded.
--------------------------------------------------------------------------------
Check manually 12   Class PHPUnit\Framework\TestCase not found and could not be
                    autoloaded.
--------------------------------------------------------------------------------

FILE: web/modules/contrib/module_builder/module_builder.info.yml

STATUS         LINE                           MESSAGE
--------------------------------------------------------------------------------
Check manually 0    Add core_version_requirement: ^8 || ^9 to
                    module_builder.info.yml to designate that the module is
                    compatible with Drupal 9. See
                    https://drupal.org/node/3070687.
--------------------------------------------------------------------------------

FILE: web/modules/contrib/module_builder/composer.json

STATUS         LINE                           MESSAGE
--------------------------------------------------------------------------------
Check manually 0    The drupal/core requirement is not Drupal 9 compatible.
                    Either remove it or update it to be compatible with Drupal
                    9. See
                    https://drupal.org/node/2514612#s-drupal-9-compatibility.
--------------------------------------------------------------------------------
CommentFileSizeAuthor
#6 3139296-6.patch47.86 KBashutosh.mishra
#2 3139296-2.patch47.55 KBashutosh.mishra

Comments

ashutosh.mishra created an issue. See original summary.

ashutosh.mishra’s picture

Status: Needs work » Needs review
StatusFileSize
new47.55 KB

Removed the deprecated code and fixed the coding standard issue from phpcbf

ashutosh.mishra’s picture

Assigned: ashutosh.mishra » Unassigned
ashutosh.mishra’s picture

Status: Needs review » Needs work

The last submitted patch, 2: 3139296-2.patch, failed testing. View results
- codesniffer_fixes.patch Interdiff of automated coding standards fixes only.

ashutosh.mishra’s picture

Status: Needs work » Needs review
StatusFileSize
new47.86 KB
joachim’s picture

Status: Needs review » Needs work

Thanks for the patch!

I'm confused about this change though:

+++ b/composer.json
@@ -5,7 +5,6 @@
-        "drupal/core": "~8.4",

Why should the minimum of 8.4 be removed here?

ashutosh.mishra’s picture

@joachim
I have removed because of below below-mentioned issue

The drupal/core requirement is not Drupal 9 compatible.   Either remove it or update it to be compatible with Drupal  9. See
                    https://drupal.org/node/2514612#s-drupal-9-compatibility.
joachim’s picture

Ah ok.

In that case, a minimum core version needs to be in the info.yml file instead.

joachim’s picture

I've committed the patch from the Rector bot issue, so this might be obsolete.

joachim’s picture

Status: Needs work » Closed (outdated)

Pretty sure I've run this on D9 now, so closing this issue.