Closed (outdated)
Project:
Module Builder
Version:
8.x-3.x-dev
Component:
Code
Priority:
Normal
Category:
Task
Assigned:
Unassigned
Reporter:
Created:
23 May 2020 at 06:44 UTC
Updated:
29 Dec 2020 at 08:52 UTC
Jump to comment: Most recent, Most recent file
Comments
Comment #2
ashutosh.mishra commentedRemoved the deprecated code and fixed the coding standard issue from phpcbf
Comment #3
ashutosh.mishra commentedComment #4
ashutosh.mishra commentedComment #6
ashutosh.mishra commentedComment #7
joachim commentedThanks for the patch!
I'm confused about this change though:
Why should the minimum of 8.4 be removed here?
Comment #8
ashutosh.mishra commented@joachim
I have removed because of below below-mentioned issue
Comment #9
joachim commentedAh ok.
In that case, a minimum core version needs to be in the info.yml file instead.
Comment #10
joachim commentedI've committed the patch from the Rector bot issue, so this might be obsolete.
Comment #11
joachim commentedPretty sure I've run this on D9 now, so closing this issue.