Problem/Motivation

Form elements should always have labels to meet accessibility criteria.

Steps to reproduce

Proposed resolution

Add a label to the select element, e.g. "Choose your 2FA method", by using the '#title' render key.

(note it would also be handy if it was possible to set the default 2FA method, including having the default method be the empty option label).

CommentFileSizeAuthor
#4 3335471-4.miniorange_2fa_label_for_select_element.patch849 bytessudhanshu_dhage

Issue fork miniorange_2fa-3335471

Command icon Show commands

Start within a Git clone of the project using the version control instructions.

Or, if you do not have SSH keys set up on git.drupalcode.org:

About issue forks
Support from Acquia helps fund testing for Drupal Acquia logo

Comments

Chris--S created an issue. See original summary.

sudhanshuD made their first commit to this issue’s fork.

sudhanshuD opened merge request !4

sudhanshu_dhage’s picture

sudhanshu_dhage CreditAttribution: sudhanshu_dhage as a volunteer commented
Status: Active » Patch (to be ported)
FileSize
3335471-4.miniorange_2fa_label_for_select_element.patch849 bytes

The patch is attached to add a label for the selected element.

Shrishail Hiremath’s picture

Shrishail Hiremath
he/him
Primary language English
CreditAttribution: Shrishail Hiremath as a volunteer and at miniOrange Inc commented
Version: 8.x-4.5 » 5.0.1
Assigned: Unassigned » Shrishail Hiremath
Status: Patch (to be ported) » Fixed

This has been taken care of in the 5.0.1

Shrishail Hiremath’s picture

Shrishail Hiremath
he/him
Primary language English
CreditAttribution: Shrishail Hiremath as a volunteer and at miniOrange Inc commented
Status: Fixed » Closed (fixed)