Hello

Thank you for all the great process plugins in this module. I used the merge plugin regulatory and noticed that it currently used array_merge within a foreach loop.

I use the EA Performance plugin for PHPStorm and one of their recommendations is to use the splat operator outside of the loop instead.

The performance gains time wise and memory wise are minimal but every little bit helps. The splat operator is available in PHP 5.6+ as well so Drupal 8 is safe in that regard.

CommentFileSizeAuthor
#2 3087401-merge-splat-2.patch663 byteslabboy0276

Comments

labboy0276 created an issue. See original summary.

labboy0276’s picture

Status: Active » Needs review
StatusFileSize
new663 bytes

Patch is attached

heddn’s picture

Status: Needs review » Reviewed & tested by the community

Thanks for the tweaks.

  • heddn committed 976f94d on 8.x-5.x authored by labboy0276
    Issue #3087401 by labboy0276, heddn: Consider Using The Splat Operator...

  • heddn committed f090876 on 8.x-4.x authored by labboy0276
    Issue #3087401 by labboy0276, heddn: Consider Using The Splat Operator...
heddn’s picture

Status: Reviewed & tested by the community » Fixed

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.

chris matthews’s picture