Needs review
Project:
Microdata
Version:
7.x-1.0-beta2
Component:
Documentation
Priority:
Minor
Category:
Feature request
Assigned:
Unassigned
Reporter:
Created:
19 Aug 2012 at 02:54 UTC
Updated:
12 Oct 2012 at 10:42 UTC
Jump to comment: Most recent, Most recent file
Comments
Comment #1
Anonymous (not verified) commentedMarked #1799020: Fatal error when saving Microdata Settings page. as a duplicate.
BTW, thanks for posting this issue. Unfortunately, I'll be focused on D8 for a few months yet, so I probably won't get a chance to properly fix this for a while, but it should definitely be fixed.
There was a reason for skipping on drupal_http_request, but unfortunately I can't remember why.
Comment #2
phizes commentedThe attached patch adds a README file based on the project page which also lists the cURL requirement. It also adds hook_requirements which prevents the module from being enabled when cURL is not available due to the REQUIREMENTS_ERROR severity level. The hook_requirements is the same as it is in the patch in this comment with minimal changes to make it refer to Microdata instead.
I have tested this patch and it works for me.
Is this in line with what you want to do?
Comment #3
Anonymous (not verified) commentedSomeone else tested drupal_http_request and had no problems, so they posted a patch in #1810126: Remove dependency on curl library in favour of drupal_http_request which I have committed.
That fixes the main problem that this issue was created for. However, the README part of the patch is still useful.
Comment #4
phizes commentedThat is a better way to solve the issue.
New patch with just the README. Is there anything else I should be including, or altering, in the README?
Comment #5
damiankloip commentedSee #1810126: Remove dependency on curl library in favour of drupal_http_request, this hopefully removes the need for this issue now. If we need this, we can re open in the future.
Comment #6
damiankloip commentedShould probably have a slightly better title too :)
Comment #7
phizes commentedThe README patch in comment 4 is just to add a README in general. The cURL dependency was removed with the commit in #1810126: Remove dependency on curl library in favour of drupal_http_request with your patch, as such this issue no longer has anything to do with the previous cURL dependency. The above mentioned patch does not mention cURL at all.
Comment #8
damiankloip commentedsorry, my mistake.