Add the changes to MetaNameBase from #3164404 so that some pieces can be properly deprecated.

CommentFileSizeAuthor
#6 metatag-n3302969-6.patch11.28 KBdamienmckenna
#3 metatag-n3302969-3.patch14.29 KBdamienmckenna

Comments

DamienMcKenna created an issue. See original summary.

damienmckenna’s picture

damienmckenna
Location TN, USA
commented
Issue tags: +Needs change record
damienmckenna’s picture

damienmckenna
Location TN, USA
commented
Status: Active » Needs review
StatusFileSize
new metatag-n3302969-3.patch14.29 KB

I think this is everything.

Status: Needs review » Needs work

The last submitted patch, 3: metatag-n3302969-3.patch, failed testing. View results

damienmckenna’s picture

damienmckenna
Location TN, USA
commented

I was able to replicate the two failures locally, so I'll dig into it a little.

damienmckenna’s picture

damienmckenna
Location TN, USA
commented
Status: Needs work » Needs review
StatusFileSize
new metatag-n3302969-6.patch11.28 KB

The mobile tag changes were moved into #3303424 because there's a bigger problem there.

damienmckenna’s picture

damienmckenna
Location TN, USA
commented
Status: Needs review » Fixed
Issue tags: -Needs change record

Committed.

damienmckenna’s picture

damienmckenna
Location TN, USA
commented
Assigned: damienmckenna » Unassigned

  • DamienMcKenna committed 1701903 on 8.x-1.x 
    Issue #3302969 by DamienMcKenna: Refactored MetaNameBase output logic.

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.