NodeSymlinks support

change status for automated test.

I'm not a fan of having module-specific logic in here. And why did you need to modify an old hook update function for drupal 6 in this patch (menu_node_update_6003) ?

This looks to be a duplicate of #1691508: Install fails with exception

Thanks for the patch. Works fine here. With this patch, when creating a node Symlink, the Menu Node API table gets also updated, so the symlinks can be retrieved with Menu Node Views to get the proper menu structure. Please consider merging...

This issue is related to #1691508 in that it seems to include the same fix, but it does more.

The problem is that nodesymlinks don't get their own row in the menu_node table this module provides. The views filters provided by Menu Node Views rely on this table and will never display menu items that don't have a row there.

I applied this patch and it does solve the problem for newly created nodesymlinks. Unfortunately, it's not working retroactively, i.e. existing nodesymlinks aren't added to menu_node.

Yes, I had to recreate the missing db entries... Perhaps this can be done with the schema version?

Here's a quick command-line script to create the rows for existing nodesymlinks.

#!/usr/bin/php -q
<?php

  $db_connection = @mysql_connect('localhost', '<username>', '<password>');
  if (!$db_connection || !@mysql_select_db('<database>', $db_connection))
    die ("Unable to connect or select database.\n");

  $result = mysql_query("SELECT link_path FROM menu_links WHERE module = 'nodesymlinks'")
    or die(mysql_error());

  while ($row = mysql_fetch_array($result))
  {
    $link_path = $row['link_path'];
    $link_path = preg_match('/node\/(\d+)\/mid\/(\d+)/', $link_path, $values);
    $nid = $values[1];
    $mlid = $values[2];
    mysql_query("INSERT INTO menu_node VALUES ($nid, $mlid)")
      or die(mysql_error());
  }