Support for per-bin key prefix

#966338: Support key prefix by bin was duplicate, also had a more up-to-date patch than here.

There are whitespace changes in litwol's patch that are unrelated to the changes here, also the patch doesn't meet code style:

+  if ( is_array($prefix) ) { //allow for granular memcache key-bin prefixes with default fallback

For example.

Uploading the patch from the duplicate here, haven't reviewed that one yet so leaving at CNR.

subscribe

Opened #1324812: Unify cache bin prefix: proposal to unified convention, I'd really like to see Memcache being well integrated with other cache backends. If my proposal ends up being adopted, you'll need to rewrite this particular patch to fit with.

Has anyone tested this patch with Drupal 6?

This is the modified patch as per the latest version of the memcache module. It supports three type of usage i.e. single key prefix for all the beans (default behavior), specific key prefix per bin, and also the default key prefix for other bins but a separate one for specific bin. Its based on comment#9.

Patch in #13 rerolled for git/makefiles + 6.x-1.10 memcache.

Ah geez, so glad that worked. I was using Domain Access and had a cache prefix for each domain so that views, etc.. wouldn't "bleed" from one domain into another.

Without the ability to set a different preset per bin (something cacherouter does out of the box PS :P) I was seeing users with a Content Profile node updating the node in one domain and not seeing the update in the other domain. Flushing memcache would sync the profile across all domains.

Clearly, to handle multisite setups correctly you need to be able to set per-bin whether the cache is to be shared by all instances of the site or to be split.

Thanks again for the patch :)

Please follow http://drupal.org/coding-standards

I've re-rolled the patch from #14 against latest 7.x-dev, tidied it up according to the coding standards, simplified slightly, and documented the feature in README.txt.

Edit: Please ignore

Fixed elseif issue in #17.

Edit: Please ignore

Re-roll and tidy up of patch in #14 against 6.x-dev, with documentation added to README.txt.

I've ported the patch from #19 to 7.x, simplified slightly, and documented the feature in README.txt.

Looks good, thanks.

But why do this, and not employ DatabaseConnection::tablePrefix? Seems to me like the need for this would be to mirror database prefixes (or lack thereof)

I guess new features would go into 7.x first, so setting back to 7.x

Also, I've re-rolled and simplified the patch a bit. Patch works for me, please review.

@fago Looks like the tags got messed up during the d.o migration. Fyi, the patch in #20 is for 7.x.

@reubenavery I don't like the idea of using tablePrefix. It's one use-case for this functionality, but there are others too. This way users can make their own decision.

I'm lowering the priority as this doesn't seem like a major issue to me.

I've just noticed the simplified patch in #22 doesn't handle the condition where there is no default prefix specified.

For example the configuration below will result in a hyphen prefix for all other keys, and throws Notice: Undefined index: default in dmemcache_key() multiple times per page load.

$conf['memcache_key_prefix'] = array(
  'cache_bootstrap' => 'cb',
  'cache_path' => 'cp',
);

The patch from #20 doesn't have this issue, so I've just rerolled it against latest head.

I've just noticed the simplified patch in #22 doesn't handle the condition where there is no default prefix specified.

That has been by purpose as I thought 'default' is required. Howsoever, the documentation should probably be clear on that.

Updated the patch from #24 against the latest version.

8 years in the making; sorry for the delay committing this. I tried to better clarify the documentation. Could be ported to 6, should be ported to 8.