Title is self explanatory.

This module is outdated and I require the module to accept the newest library the Drupal way.

CommentFileSizeAuthor
#7 mediaelement-2863615-7.patch515 bytesdtarc
#3 7.x-update-mediaelement-library-2863615-3.patch666 bytesdave kopecek
#2 7.x-update-mediaelement-library-2863615.patch542 bytesmichel.g

Comments

michel.g created an issue. See original summary.

michel.g’s picture

michel.g commented
StatusFileSize
new 7.x-update-mediaelement-library-2863615.patch542 bytes

Added patch with increases the version number in the library hook. Everything still works, you just got to download the 4.0.2 library.

dave kopecek’s picture

dave kopecek
he/him
commented
StatusFileSize
new 7.x-update-mediaelement-library-2863615-3.patch666 bytes

Just bumped the library to 4.0.5

dave kopecek’s picture

dave kopecek
he/him
commented
Title: Update the library hook to accept the newest mediaelement javascript library (in this case 4.0.2) » Update library hook to newest mediaelement javascript library - v4.05
Status: Active » Needs review
brockfanning’s picture

brockfanning commented

I'm trying out the latest version available, 4.2.5, and it seems to work fine without any patches. Is this patch needed for any functionality, or is it purely for documentation?

chris matthews’s picture

chris matthews commented

The latest release as of 4/30/18 (4.2.9) is working ok for me. https://github.com/mediaelement/mediaelement/releases/tag/4.2.9

dtarc’s picture

dtarc commented
StatusFileSize
new mediaelement-2863615-7.patch515 bytes

I'm using MediaElement 4.2.9, embedding videos with Media Colorbox. If I leave the old version in mediaelement.module, 2.1.6, I get some display issues within the Colorbox. If I update the version number in mediaelement_library, the display issues go away.

Removing the version line completely also fixes my display issues. Since this version property is totally optional, I think it's better to remove it entirely. That way no future patches are needed to update to later versions.

Here's a patch with that line removed.

chris matthews’s picture

chris matthews commented
Version: 7.x-1.2 » 7.x-1.x-dev

Since this version property is totally optional, I think it's better to remove it entirely. That way no future patches are needed to update to later versions.

- Agreed!

The patch in #7 applied cleanly to 7.x-1.x-dev and resolves this issue.

chris matthews’s picture

chris matthews commented
Status: Needs review » Reviewed & tested by the community

  • dtarc authored 2fb042f on 7.x-1.x 
    Issue #2863615 by michel.g, Dave Kopecek, dtarc, jnettik: Update library...
jnettik’s picture

jnettik
Primary language English
Location Denver, CO
commented
Status: Reviewed & tested by the community » Fixed

Thank you. This has been committed.

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.