The settings form is missing the variable as default value, so changing it requires writting everytime you save the settings.
$form['mailhandler_default_encoding'] = array(
'#type' => 'textfield',
'#title' => t('Default character encoding'),
'#default_value' => 'UTF-8',
'#description' => t('The default character encoding to use when an incoming message does not define an encoding.')
);
should be '#default_value' => variable_get('mailhandler_default_encoding', 'UTF-8'),
| Comment | File | Size | Author |
|---|---|---|---|
| #1 | mailhandler_default_encoding.patch | 1.88 KB | ilo |
Comments
Comment #1
ilo commentedA check is already included in the testcase.
Comment #3
ilo commentedDespite the notices, the encoding errors dissapear with the patch. Notices are being handled in #300389: Fix some PHP notices on mailbox administrative interface.. Someone wants to review and rtbc?
Comment #4
ilo commentedCommitted, required to pass the tests for the Drupal 7 module upgrade.
Comment #5
cor3huis commentedOh, I'm to late reviewing ;) at the pace you patch I need to make sure I'm even faster. Was busy adjusting listhandler and a 6000+ old mail import i had to wait for finishing.
So, anyhow, patch looks fine to me, could not come up with negative side effects, THX!