The settings form is missing the variable as default value, so changing it requires writting everytime you save the settings.

  $form['mailhandler_default_encoding'] = array(
    '#type' => 'textfield',
    '#title' => t('Default character encoding'),
    '#default_value' => 'UTF-8',
    '#description' => t('The default character encoding to use when an incoming message does not define an encoding.')
  );

should be '#default_value' => variable_get('mailhandler_default_encoding', 'UTF-8'),

CommentFileSizeAuthor
#1 mailhandler_default_encoding.patch1.88 KBilo

Comments

ilo’s picture

Status: Needs work » Needs review
StatusFileSize
new1.88 KB

A check is already included in the testcase.

Status: Needs review » Needs work

The last submitted patch, mailhandler_default_encoding.patch, failed testing.

ilo’s picture

Despite the notices, the encoding errors dissapear with the patch. Notices are being handled in #300389: Fix some PHP notices on mailbox administrative interface.. Someone wants to review and rtbc?

ilo’s picture

Title: variable mailhandler_default_encoding in system settings form. » Default encoding not being shown in system settings form.
Status: Needs work » Fixed

Committed, required to pass the tests for the Drupal 7 module upgrade.

cor3huis’s picture

Oh, I'm to late reviewing ;) at the pace you patch I need to make sure I'm even faster. Was busy adjusting listhandler and a 6000+ old mail import i had to wait for finishing.

So, anyhow, patch looks fine to me, could not come up with negative side effects, THX!

Status: Fixed » Closed (fixed)

Automatically closed -- issue fixed for 2 weeks with no activity.