The following testcase is just an start point. It verifies that the administrator interface is working, and currently shows several issues: notices in add/edit/clone/delete form processing, a variable not being set in the settings page and a simple string format issue.

I can not upload patches for these issues because they are in the admin.inc file, that has double endline markers as I posted in #1038910: Wrong endline marker in mailhandler.admin.inc file.. Any attempt to create a patch for me lands in a complete file being changed.

CommentFileSizeAuthor
#8 mailhandler_imap_test.patch885 bytesilo
#7 mailhandler_imap_test.patch912 bytesilo
#6 mailhandler_imap_test.patch889 bytesilo
#4 mailhandler_test_mailbox.patch3.91 KBilo
#2 mailhandler_test_mailbox.patch3.9 KBilo
#1 mailhandler_testcase.patch12.24 KBilo
mailhandler_testcase.patch11.83 KBilo

Comments

ilo’s picture

ilo commented
Status: Needs review » Fixed
StatusFileSize
new mailhandler_testcase.patch12.24 KB

I've committed (http://drupal.org/cvs?commit=488698) a modified version of this patch to reduce the noise and be able to test following patches. From now on, code changing patches will include their custom test checks.

This is the last commit to have a working testable base and keep submitting patches.

ilo’s picture

ilo commented
Title: Include mailhandler simpletest testcase. » Verify basic mailbox operations in simpletest testcase.
Category: feature » task
Status: Fixed » Needs review
StatusFileSize
new mailhandler_test_mailbox.patch3.9 KB

Before we start the clean up, this updated testcase will verify it is able to open a mailbox and some basic authorization. The test function is minimal, as long as it will only verify the parts that we are going to touch in further patches.

Status: Needs review » Needs work

The last submitted patch, mailhandler_test_mailbox.patch, failed testing.

ilo’s picture

ilo commented
Status: Needs work » Needs review
StatusFileSize
new mailhandler_test_mailbox.patch3.91 KB

Rerolling..

Status: Needs review » Needs work

The last submitted patch, mailhandler_test_mailbox.patch, failed testing.

ilo’s picture

ilo commented
Status: Needs work » Needs review
StatusFileSize
new mailhandler_imap_test.patch889 bytes

mmm

ilo’s picture

ilo commented
StatusFileSize
new mailhandler_imap_test.patch912 bytes

lets see

ilo’s picture

ilo commented
StatusFileSize
new mailhandler_imap_test.patch885 bytes

ammm.. this is taking me crazy :)

Status: Needs review » Needs work

The last submitted patch, mailhandler_imap_test.patch, failed testing.

ilo’s picture

ilo commented

Well, this is a problem. I'll try to find a way to get this working, but the testbot does not have the imap extension available.

danepowell’s picture

danepowell commented

I was wondering how exactly this would work... I didn't figure that Simpletest would support anything related to retrieving email, which defeats about 90% of its usefulness for us... let me know if you figure out how to get this working.

danepowell’s picture

danepowell commented
Component: Code » Mailhandler
Status: Needs work » Closed (won't fix)

Sorry, 6.x-1.x is no longer a supported release. Please try upgrading to 6.x-2.x and reopen if still an issue.