Port Mailfix module to D7

Hello Mapi99,

Do you need CVS access? There's currently no D7 version, so if you want your version to become the official trunk, this would be awesome.

Nigel, do you agree?

Best regards,

A. Saavedra

Thanks for asking for my input - I'm seeing a similar discussion with regard to og_mailinglist, and didn't realise at first that this was dealing with Mailfix!

Mapi99, would you post your code where we can see it? We can then review it and decide whether we're happy to have it be the D7 branch.

I'm generally in favour of the idea, but I'd like to see what the differences are in your version. Perhaps we can get them equivalent in functionality.

Regards,

Nigel

By the way, I'd be interested to know what you did (if anything) about Postfix integration.

I'm imagining that I'll need to add support for the salted passwords to libpammysql (assuming I remember it's name right).

Regards,

Nigel

I'll email you my address shortly.

I'd rather have it work 'out of the box', so I'll work on submitting a patch to libpam-mysql when I find some time.

Nigel

We could have a password field in Mailfix tables, and synchronize it with Drupal password through hook_user_update. This password could be encrypted using non-salted MD5, which Postfix supports out of the box.

That's an idea. It does undo the security improvements in D7 though, and would probably earn us a security alert! :)

No, I agree.

I want to create a patch to libpam-mysql to let the Postfix side of things be able to handle the salted passwords. Once I get around to that, I'll put effort into a D7 port (if we haven't seen anything from you by then).

First cut of a patch against libpam-mysql as it is found in Ubuntu Maverick.

Completely untested - just put here so it doesn't get misplaced.

First working version of the patch against pam-mysql.

This is prepared against the Ubuntu Maverick source, but shouldn't be too hard to apply for other distros. Pam-MySql looks quite badly maintained. I might try contacting the developers to see if I can take it off their hands.

With this patch applied, I can successfully authenticate using the email address and salted password of a row in a D7 user table. The only change to my configuration from doing this in D6 is to modify /etc/pam.d/dovecot to say "crypt=5" instead of "crypt=3". This makes it use the new D7 code.

#%PAM-1.0
auth    sufficient   pam_mysql.so user=pam passwd=pam_test host=127.0.0.1 db=drupal7 table=users usercolumn=mail passwdcolumn=pass crypt=5
account sufficient pam_mysql.so user=pam passwd=pam_test host=127.0.0.1 db=drupal7 table=users usercolumn=mail passwdcolumn=pass crypt=5

@include common-auth
@include common-account
@include common-session

The test:

pamtester -v dovecot nigel@tuxonice.net authenticate
pamtester: invoking pam_start(dovecot, nigel@tuxonice.net, ...)
pamtester: performing operation - authenticate
Password:
pamtester: successfully authenticated

Now work can begin on porting Mailfix itself :)

Oh, you might like the actual patch, too :)

I'm working on the Fasttoggle port at the moment, and will come back to Mailfix after that.

Great! Thanx for the update Nigel ;)

Started a 7.x-1.x branch. Not usable yet.

Just thought I'd let you know I'm plodding away, getting my head around the changes to the form API and database querying. Getting there slowly :)

Is the D7 port still in progress(ie. not dead)? I wish I could help but I'm still learning Drupal!

It's not dead. It's just that I'm working on a couple of other projects, and they're swallowing all available time at the moment. Sorry!

Making some progress - the base module is ready for testing; currently working on the mailfix_admin module.

I see that as of last month this was in need of testing... If the module is ready, I would like to help test and help in whatever ways I can.

Best,
Travis Payne

The base module (mailfix itself) should be usable, and I'd appreciate feedback on it. I'm still trying to find time to finish off the other modules (views integration and so on).

Regards,

Nigel

There already exists a 7.x dev version for all of us that want to test things and provide feedback, so I think we should mark this task here as fixed (we do have an initial -partially- working version after all). Let's just file separate issues for missing features against the 7.x branch, shall we? This way it will be easier for people to test specific things and provide better feedback.