Come together with the global Drupal community in Rotterdam, 28 Sept – 1 Oct 2026. Sessions, contribution, connection, and Early Bird savings until 8 June.Problem/Motivation
Log 2.x added support for revisions of log entities, and used the Entity API module's RevisionRouteProvider to build the /log/%/revisions route.
https://git.drupalcode.org/project/log/-/commit/a061d7ba3498cf6393f77144...
At the time, Drupal core only provided a revisions overview route for nodes, but since then core has expanded to provide a generalized RevisionHtmlRouteProvider for any revisionable entity type (#2350939: Implement a generic revision UI).
Proposed resolution
Let's start using core's route provider instead of Entity API's.
Remaining tasks
- Add
revision_data_tableto log entity type definition. - Use Drupal core
RevisionHtmlRouteProvider. - Open MR.
User interface changes
None.
API changes
None.
Data model changes
None.
Issue fork log-3600574
Show commands
Start within a Git clone of the project using the version control instructions.
Or, if you do not have SSH keys set up on git.drupalcode.org:
changes
Comments
Comment #2
m.stentaIn testing this, I ran into the following issue (originally discovered by @paul121): #3596981: Uncaught PHP Exception: revision_translation_affected not found
We will need to add
revision_data_tableto theLogentity type definition, and provide an update hook for existing installs.Comment #3
m.stentaComment #4
m.stentaComment #7
m.stentaComment #9
m.stentaThis change was not enough... now the revisions tab is showing "Access denied", because Drupal core's routes use different access checking than Entity API's.
I opened a follow-up issue to fix this: #3601012: Fix access to log entity revisions