From https://github.com/localgovdrupal/localgov_guides/issues/11

We're following Keelan's suggestion above:

  1. don't require the Guide section title
  2. fall back on the Title if the Guide section title is blank

Check that Step by Step is the same

Command icon Show commands

Start within a Git clone of the project using the version control instructions.

Or, if you do not have SSH keys set up on git.drupalcode.org:

Comments

markconroy created an issue. See original summary.

markconroy’s picture

Status: Active » Needs review

MR attached. Simple changing the field from required to not required seemed to be enough. No custom code needed, unless I'm missing something.

tonypaulbarker’s picture

Status: Needs review » Needs work

I think some work needed on the fallbacks.

Reverse the logic in GuidesPrevNextBlock.php to use the section title if it exists and only the title if it is blank. I think at the moment we never get to the section title if the title is there.
Add a fallback to GuidesContentsBlock.php I don't think there is a fallback there.