Add core_version_requirement: ^8 || ^9 to livechat.info.yml to designate that the module is compatible with Drupal 9. See https://drupal.org/node/3070687.

drupal-check -d web/modules/custom/livechat
3/3 [▓▓▓▓▓▓▓▓▓▓▓▓▓▓▓▓▓▓▓▓▓▓▓▓▓▓▓▓] 100%

------ ----------------------------------------------------------------------
Line livechat.install
------ ----------------------------------------------------------------------
17 Call to deprecated method url() of class Drupal:
in drupal:8.0.0 and is removed from drupal:9.0.0.
Instead create a \Drupal\Core\Url object directly, for example using
Url::fromRoute().
------ ----------------------------------------------------------------------

CommentFileSizeAuthor
#2 livechat-drupal_9_readiness-3139291-2.patch1.25 KBvatsalkhanna

Comments

vatsalkhanna created an issue. See original summary.

vatsalkhanna’s picture

vatsalkhanna commented
Assigned: vatsalkhanna » Unassigned
Issue summary: View changes
Status: Active » Needs review
StatusFileSize
new livechat-drupal_9_readiness-3139291-2.patch1.25 KB
jaykandari’s picture

jaykandari
Primary language Hindi
commented
Status: Needs review » Reviewed & tested by the community

Thank you @vatsalkhanna for the patch.

Patch #2 applies cleanly.

Upgrade status module also reports no issues after applying patch.

Ran Rector & Drupal-check: These reported no errors after applying patch.

❯ vendor/bin/rector process ./modules/custom/livechat --dry-run
Rector 0.8.x-dev@80f429b
Config file: rector.yml

 9/9 [▓▓▓▓▓▓▓▓▓▓▓▓▓▓▓▓▓▓▓▓▓▓▓▓▓▓▓▓] 100%

                                                                                                                        
 [OK] Rector is done!                                                                                                   
                                                                                                                        

                                                                                                                                                                                                            
drupal89 git/8.9.x*  6s
❯ drupal-check -ad modules/custom/livechat 

 3/3 [▓▓▓▓▓▓▓▓▓▓▓▓▓▓▓▓▓▓▓▓▓▓▓▓▓▓▓▓] 100%

                                                                                                                        
 [OK] No errors

Thus marking it as RTBC

ajv009’s picture

ajv009
He/Him
Primary language English
Location Maharashtra
commented

Cant we just merge this and release a new version!

lindsay.wils’s picture

lindsay.wils commented

Thanks for this patch. I am still having an issue upgrading to D9 because of the line 12 in .info.yml file

core: '8.x'

Unfortunately I have no idea how to create patches, any chance this can be updated to remove this line?

Thanks in advance

dreg’s picture

dreg commented

Second vote for merging this patch asap. I have a composer based D8 site I can't update due to the info file. Patch looks good / applies cleanly.

  • vatsalkhanna authored 72f1ec3 on 8.x-3.x 
    Issue #3139291 by vatsalkhanna, JayKandari: Drupal 9 Readiness
markie’s picture

markie commented

Pushed this to the dev branch. Want to test before adding a release.

markie’s picture

markie commented
Status: Reviewed & tested by the community » Fixed

Patch applied and tested locally on 9.3.0 with no issues. Working on a new release now.

markie’s picture

markie commented
Status: Fixed » Closed (fixed)

New release is out. Thanks for your help on this.

lindsay.wils’s picture

lindsay.wils commented

Amazing, thanks so much, will apply this today.