Problem/Motivation

In my project, content items are translated into more than 20 languages. In this situation, the extraction also requires 20x more resource. Fortunately, we can assume that the URLs of the links are the same everywhere, so the easiest performance improvement is to only check the links in the default translations.

Proposed resolution

* Add a new config option: "check_translations"; default to true (for BC reasons).
* In \Drupal\linkchecker\LinkExtractorService::extractFromEntity, check the value of the setting.

Remaining tasks

  1. MR with code
  2. test

User interface changes

Nothing.

API changes

New option which allows to disable checking all translations.

Data model changes

Nothing.

CommentFileSizeAuthor
#9 linkchecker-3614972-check-entity-translations--no-tests-9.diff8.77 KBcodebymikey
#8 linkchecker-3614972-check-entity-translations--no-tests-8.diff3.8 KBcodebymikey
#6 linkchecker-3614972-check-entity-translations--no-tests-6.diff3.73 KBcodebymikey

Issue fork linkchecker-3614972

Command icon Show commands

Start within a Git clone of the project using the version control instructions.

Or, if you do not have SSH keys set up on git.drupalcode.org:

About issue forks

Comments

huzooka created an issue. See original summary.

huzooka opened merge request !157

huzooka’s picture

huzooka
Primary language Hungarian
Location Hungary 🇭🇺🇪🇺
commented
Title: Option to check only default translation » Provide option to only check links found in default translation

codebymikey made their first commit to this issue’s fork.

codebymikey’s picture

codebymikey commented
Status: Active » Needs review
codebymikey’s picture

codebymikey commented
StatusFileSize
new linkchecker-3614972-check-entity-translations--no-tests-6.diff3.73 KB

Attached static patch without tests to reduce conflict with other issues.

huzooka’s picture

huzooka
Primary language Hungarian
Location Hungary 🇭🇺🇪🇺
commented
Assigned: huzooka » Unassigned
codebymikey’s picture

codebymikey commented
StatusFileSize
new linkchecker-3614972-check-entity-translations--no-tests-8.diff3.8 KB

Attached a version of the patch with the fixed update hook.

codebymikey’s picture

codebymikey commented
StatusFileSize
new linkchecker-3614972-check-entity-translations--no-tests-9.diff8.77 KB
dimilias’s picture

dimilias commented
Status: Needs review » Reviewed & tested by the community

This seems to be working as expected. I tested it in our projects and could avoid checking translated links.