Problem/Motivation

The recent commit ("README.md file update with Geofield Map widget integration"):
https://git.drupalcode.org/project/leaflet_maptiler/-/commit/b7944d72a29...

looks totally not pertinent with this leaflet_maptiler module.

The Geofield Map module is a totally independent module from this one, and even not dependent from the Leaflet module itself.

As explained here: https://www.drupal.org/project/geofield_map/issues/3590864
the Geofield Map has its own LeafletTileLayerPlugin plugins system/api to add Map Tiles, and also Maptiler tiles ... (totally un-related from this module)

Steps to reproduce

Proposed resolution

Rollback the commit: https://git.drupalcode.org/project/leaflet_maptiler/-/commit/b7944d72a29...
and don't mention the Geofield Map in this module.

Comments

itamair created an issue. See original summary.

itamair’s picture

itamair commented
Related issues: +#3590864: Support Maptiler tile layers in the Geofield Map widget via LeafletTileLayerPlugin
orkutmuratyilmaz’s picture

orkutmuratyilmaz
Primary language Turkish
Location İzmir
commented
Assigned: Unassigned » orkutmuratyilmaz
orkutmuratyilmaz’s picture

orkutmuratyilmaz
Primary language Turkish
Location İzmir
commented
Status: Active » Needs work

@itamair, thanks for your warning. The fix is already done and pushed. The 2973a5c commit (already on origin/2.x) removed the "## Geofield Map widget integration" section and replaced it with "## Per-style map entries" with no mention of Geofield Map. No Geofield Map references remain in the README.md file now. But I'd try reverting the commits soon.

orkutmuratyilmaz’s picture

orkutmuratyilmaz
Primary language Turkish
Location İzmir
commented
Assigned: orkutmuratyilmaz » Unassigned
Status: Needs work » Fixed
Related issues: +#3591060: Mention Maptiler Raster Tiles already supported natively in Leaflet module

Instead of reverting the commits, I've just added a new commit, fixint this is issue and #3591060 together.

Now that this issue is closed, review the contribution record.

As a contributor, attribute any organization that helped you, or if you volunteered your own time.

Maintainers, credit people who helped resolve this issue.