More information #2756323: [leaflet_mapbox] Leaflet MapBox

Comments

tobiasb created an issue. See original summary.

tobiasb’s picture

tobiasb
Primary language German
Location Berlin
commented
Issue summary: View changes
tobiasb’s picture

tobiasb
Primary language German
Location Berlin
commented
Issue summary: View changes
tobiasb’s picture

tobiasb
Primary language German
Location Berlin
commented
Issue summary: View changes
tobiasb’s picture

tobiasb
Primary language German
Location Berlin
commented
Status: Active » Needs review
heliogabal’s picture

heliogabal
Primary language German
Location Berlin
commented
Status: Needs review » Active

Hi tobias,

Thanks for having started this! I tested the sandbox module and it works great out of the box for me. Can we get a dev release on drupal.org please? Or what is holding this back? I wish I could help, but I'm not a programmer, so I don't know how this would work in that case.

tobiasb’s picture

tobiasb
Primary language German
Location Berlin
commented
Status: Active » Needs review

I am not the maintainer of Leaflet MapBox. Therefore it is better to ask a maintainer that they should take the time to review and release a D8 version.

shadcn’s picture

shadcn commented

@tobiasb Can we go ahead and add your sandbox code to a d8 branch here?

tobiasb’s picture

tobiasb
Primary language German
Location Berlin
commented

@arshadcn You are one of the maintainer. Sure you can create a branch for D8 and add the code. ;-)

finn lewis’s picture

finn lewis
Location Oxford
commented

I just tested the sandbox at https://www.drupal.org/project/contrib_tracker/issues/2756323#comment-13... and it works for me.

Can we get this released as a dev at least?

heliogabal’s picture

heliogabal
Primary language German
Location Berlin
commented
Version: 7.x-1.x-dev » 8.x-1.x-dev
Status: Needs review » Active

dev version based on the sandbox of @tobiasb is now available for further review: https://www.drupal.org/project/leaflet_mapbox/releases/8.x-1.x-dev

finn lewis’s picture

finn lewis
Location Oxford
commented

Great, thanks @heliogabal, that was swift!

hanness’s picture

hanness
Primary language German
commented

Thanks @tobiasb for the early port!

Thank @heliogabal for the dev release - what about releasing an alpha as well? I do not see any blockers for that.

Than we could close this issue. Otherwise I would close it as well and maybe create a D8 (alpha) Roadmap issue.

ericdsd’s picture

ericdsd commented

It works great for me too +1 for alpha release

heliogabal’s picture

heliogabal
Primary language German
Location Berlin
commented
Assigned: Unassigned » heliogabal
Status: Active » Fixed

I added the Drupal Rector Automated D9 compatibility patch to the dev version and released a first alpha1.

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.