Problem/Motivation

We currently implement the reset map button locally within our Drupal Leaflet module's JS, with just text based icon.

This PR introduce a replacement of functionality with https://github.com/hswong3i/Leaflet.ResetView, with:

  • Font Awesome based icon
  • Customizable position
  • Customizable title

Issue fork leaflet-3254074

Command icon Show commands

Start within a Git clone of the project using the version control instructions.

Or, if you do not have SSH keys set up on git.drupalcode.org:

About issue forks

Comments

hswong3i created an issue. See original summary.

hswong3i opened merge request !10

hswong3i’s picture

hswong3i commented
Title: Refine Reset Map with hswong3i/Leaflet.ResetView » Refine Reset Map with drustack/Leaflet.ResetView
Status: Active » Needs review
hswong3i’s picture

hswong3i commented
Version: 2.1.x-dev » 3.0.x-dev

  • hswong3i committed a8163b4 on 3.0.x 
    Issue #3254074 by hswong3i: Refine Reset Map with drustack/Leaflet....

  • itamair committed 0e23237 on 3.0.x 
    Revert "Issue #3254074 by hswong3i: Refine Reset Map with drustack/...
itamair’s picture

itamair commented
Status: Needs review » Needs work

This cannot be approved as it is based on the 3.0.x-dev branch that is only experimental and not being supported now, in the short & mid term, because it doesn't provide a smooth and automatic upgrade path for all the 2.x users.

All this features requests should be also smoothly applicable to the 2.x branch, with full BW compatibility into it and upgrade/update path, to be approved ...

itamair closed merge request !10

itamair’s picture

itamair commented
Status: Needs work » Closed (outdated)