Needs review
Project:
Leaflet
Version:
7.x-1.x-dev
Component:
Code
Priority:
Normal
Category:
Feature request
Assigned:
Unassigned
Reporter:
Created:
12 Aug 2013 at 01:55 UTC
Updated:
8 Nov 2018 at 19:22 UTC
Jump to comment: Most recent, Most recent file
Comments
Comment #1
mstrelan commentedNot sure why but sometimes the items passed to leaflet_process_location() in the previous patch were not actually location items. This is resolved in the attached patch.
Comment #2
rdeboerHi Michael,
Thanks for contributing this patch.
As far as the integration of leaflet_views is concerned, are you aware of IP Geolocation Views and Maps?
Rik
Comment #3
mstrelan commentedWow, no, I was not aware of that module. It looks fantastic, thanks.
Comment #4
rdeboerCovered by IPGV&M.
Comment #5
kpaxman commentedWe wanted to be able to use Leaflet with Location as well, and found that IPGV&M didn't let us use it as a field formatter, so we came back to this patch. It didn't apply against the current version, so we're working on an updated version and will add it here when it's ready.
Comment #6
lily.yan commentedHere is the patch mentioned above.
Comment #7
kpaxman commentedComment #8
itamair commentedTnx and sorry ... It seems that I am the only active maintainer for the Leaflet module, but actually I am taking care of the 8.x branch,
and not able to follow, fix bugs and face features requests, and even review functionalities.
Actually I don't even have a Drupal 7 playground (and don't have time to set it up) to test them.
Evan I am not able to grant new maintainer privileges.
So ... I would be able just to commit new patches to dev, and just if they are 99% tested and reviewed by you external contributors.
So do that, and eventually under your responsibility ask me to commit to dev if really needed (will try to do that in my spare time).
Comment #9
lily.yan commentedThis patch includes the changes of leaflet views module in order to make sure leaflet views can support location correctly.