user warning: You have an error in your SQL syntax; check the manual that corresponds to your MySQL server version for the right syntax to use near '%' at line 1 query: UPDATE users SET status = 1 where uid = % in /srv/www/htdocs-test/sites/all/modules/ldap_integration/ldapsync.module on line 136.

The current code is -

db_query("UPDATE {users} SET status = %d where uid = %", 1, $account->uid);

This is obviously missing a placeholder for the uid variable. Correct patch is attached. Unfortunately, I'm unable to test this with a proper patch, will request confirmation from client tomorrow.

CommentFileSizeAuthor
ldapsync-fix-broken-user-status-sql.patch804 byteserikwebb

Comments

erikwebb’s picture

Priority: Normal » Critical

As this code entirely breaks this piece of functionality, I'd consider it critical.

johnbarclay’s picture

Status: Needs review » Closed (won't fix)

this is a different module/package.

zanix’s picture

ldapsync was added to this module in the master branch
http://drupalcode.org/project/ldap_integration.git/commit/6afa43aa528088...

johnbarclay’s picture

Assigned: Unassigned » johnbarclay
Status: Closed (won't fix) » Active

ok. I'll get it back in head.

johnbarclay’s picture

Version: master » 6.x-1.x-dev
Status: Active » Fixed

I committed this, and got ldap synch back in head.

Status: Fixed » Closed (fixed)
Issue tags: -ldapsync

Automatically closed -- issue fixed for 2 weeks with no activity.