Error loading the overrides form when using a ResourceFieldEnhancer with a PHP attribute

Problem/Motivation

Steps to reproduce

- Install jsonapi_extras and enable
- Browse to the overrides tab

The website encountered an unexpected error. Try again later.

TypeError: Cannot access offset of type array in isset or empty in Drupal\Core\Extension\ModuleHandler->moduleExists() (line 267 of core/lib/Drupal/Core/Extension/ModuleHandler.php).

Drupal\hook_event_dispatcher\HookEventDispatcherModuleHandler->moduleExists(Array) (Line: 55)

Drupal\jsonapi_extras\Plugin\ResourceFieldEnhancerManager->alterDefinitions(Array) (Line: 344)

Drupal\Core\Plugin\DefaultPluginManager->findDefinitions() (Line: 216)

Drupal\Core\Plugin\DefaultPluginManager->getDefinitions() (Line: 412)

Drupal\jsonapi_extras\Form\JsonapiResourceConfigForm->buildOverridesField('nid', Object) (Line: 309)

Drupal\jsonapi_extras\Form\JsonapiResourceConfigForm->buildOverridesForm(Object, Object) (Line: 138)

Drupal\jsonapi_extras\Form\JsonapiResourceConfigForm->form(Array, Object) (Line: 108)

Drupal\Core\Entity\EntityForm->buildForm(Array, Object)

call_user_func_array(Array, Array) (Line: 559)

Drupal\Core\Form\FormBuilder->retrieveForm('jsonapi_resource_config_add_form', Object) (Line: 299)

Drupal\Core\Form\FormBuilder->buildForm(Object, Object) (Line: 73)

Drupal\Core\Controller\FormController->getContentResult(Object, Object)

call_user_func_array(Array, Array) (Line: 123)

Drupal\Core\EventSubscriber\EarlyRenderingControllerWrapperSubscriber->{closure:Drupal\Core\EventSubscriber\EarlyRenderingControllerWrapperSubscriber::wrapControllerExecutionInRenderContext():121}() (Line: 638)

Drupal\Core\Render\Renderer::{closure:Drupal\Core\Render\Renderer::executeInRenderContext():638}()

Fiber->resume() (Line: 653)

Drupal\Core\Render\Renderer->executeInRenderContext(Object, Object) (Line: 121)

Drupal\Core\EventSubscriber\EarlyRenderingControllerWrapperSubscriber->wrapControllerExecutionInRenderContext(Array, Array) (Line: 97)

Drupal\Core\EventSubscriber\EarlyRenderingControllerWrapperSubscriber->{closure:Drupal\Core\EventSubscriber\EarlyRenderingControllerWrapperSubscriber::onController():96}() (Line: 183)

Symfony\Component\HttpKernel\HttpKernel->handleRaw(Object, 1) (Line: 76)

Symfony\Component\HttpKernel\HttpKernel->handle(Object, 1, 1) (Line: 54)

Drupal\simple_oauth\HttpMiddleware\BasicAuthSwap->handle(Object, 1, 1) (Line: 53)

Drupal\Core\StackMiddleware\Session->handle(Object, 1, 1) (Line: 30)

Drupal\Core\StackMiddleware\KernelPreHandle->handle(Object, 1, 1) (Line: 28)

Drupal\Core\StackMiddleware\ContentLength->handle(Object, 1, 1) (Line: 32)

Drupal\big_pipe\StackMiddleware\ContentLength->handle(Object, 1, 1) (Line: 118)

Drupal\page_cache\StackMiddleware\PageCache->pass(Object, 1, 1) (Line: 92)

Drupal\page_cache\StackMiddleware\PageCache->handle(Object, 1, 1) (Line: 48)

Drupal\Core\StackMiddleware\ReverseProxyMiddleware->handle(Object, 1, 1) (Line: 51)

Drupal\Core\StackMiddleware\NegotiationMiddleware->handle(Object, 1, 1) (Line: 71)

Drupal\Core\StackMiddleware\AjaxPageState->handle(Object, 1, 1) (Line: 54)

Drupal\Core\StackMiddleware\StackedHttpKernel->handle(Object, 1, 1) (Line: 753)

Drupal\Core\DrupalKernel->handle(Object) (Line: 34)

Symfony\Component\Runtime\Runner\Symfony\HttpKernelRunner->run() (Line: 32)

require('/Sites/wwguidenew/vendor/autoload_runtime.php') (Line: 22)

require_once('/Sites/wwguidenew/web/autoload_runtime.php') (Line: 13)

Proposed resolution

Filter out non strings

+ $modules = array_filter($definition_info['requiredModules'], 'is_string');
+ return !$modules ? [] : array_values($modules);

Probably caused by another module ruining the definitions?

Remaining tasks