Backport #2990532: Terms are now publishable in 8.6+

+++ b/tests/src/Kernel/Normalizer/JsonApiDocumentTopLevelNormalizerTest.php
@@ -265,10 +265,11 @@ class JsonApiDocumentTopLevelNormalizerTest extends JsonapiKernelTestBase {
-    $this->assertEquals($this->term1->uuid(), $normalized['included'][0]['id']);
-    $this->assertEquals('taxonomy_term--tags', $normalized['included'][0]['type']);
-    $this->assertEquals($this->term1->label(), $normalized['included'][0]['attributes']['name']);
-    $this->assertTrue(!isset($normalized['included'][0]['attributes']['created']));
+    $this->assertEquals($this->term1->uuid(), $normalized['included'][1]['id']);
+    $this->assertEquals('taxonomy_term--tags', $normalized['included'][1]['type']);
+    $this->assertEquals($this->term1->label(), $normalized['included'][1]['attributes']['name']);
+    $this->assertCount(floatval(\Drupal::VERSION) >= 8.6 ? 9 : 8, $normalized['included'][1]['attributes']);
+    $this->assertTrue(!isset($normalized['included'][1]['attributes']['created']));

First, I thought this was porting part of #2843922: Show label of inaccessible entities ('view' access denied) when 'view label' access is allowed … but then I realized that in fact it was simply the set of includes that resolves to a differently ordered list on 8.6 vs 8.5.

• 8.5: [term1, term2, file]
• 8.6 and 8.7: [file, term1, term2]

Why? 🤔

On 8.6 + 8.7, iterating over the fields of a Node entity returns field_image, then field_tags. On 8.5, it's the other way around!

To convince yourself, run \Drupal\Tests\jsonapi\Kernel\Normalizer\JsonApiDocumentTopLevelNormalizerTest::testNormalize() and put a breakpoint in EntityNormalizerValue:__construct(); make it break on the condition $entity instanceof \Drupal\node\NodeInterface, and then evaluate this:

\Drupal\Core\TypedData\TypedDataInternalPropertiesHelper::getNonInternalProperties($entity->getTypedData())

You'll be able to confirm the different field order.

We could ask "why?" again, but there's no point to it: this is a subtle change in core that does not change the data model, so it is a fair change. I could find the exact core commit that caused this, but there's no point to doing that other than satisfying our curiosity :)

Green on 8.5+8.6+8.7 ✅