HEAD is broken on Drupal 8.6 and above.

That's because #2981887: Add a publishing status to taxonomy terms introduced a new status attribute to terms. See the change record here: https://www.drupal.org/node/2985366

We need to update our test expectations for this case.

CommentFileSizeAuthor
#9 interdiff-commit.txt479 bytesgabesullice
#6 2990532-5.patch3.15 KBgabesullice
#5 interdiff-3-5.txt2.71 KBgabesullice
#3 2990532-3.patch645 bytesgabesullice

Comments

gabesullice created an issue. See original summary.

gabesullice’s picture

gabesullice
Primary language English
commented
Issue summary: View changes

Updated the IS.

gabesullice’s picture

gabesullice
Primary language English
commented
Status: Active » Needs review
StatusFileSize
new 2990532-3.patch645 bytes

Status: Needs review » Needs work

The last submitted patch, 3: 2990532-3.patch, failed testing. View results

gabesullice’s picture

gabesullice
Primary language English
commented
Status: Needs work » Needs review
StatusFileSize
new interdiff-3-5.txt2.71 KB

These should pass.

gabesullice’s picture

gabesullice
Primary language English
commented
StatusFileSize
new 2990532-5.patch3.15 KB

😅

Status: Needs review » Needs work

The last submitted patch, 6: 2990532-5.patch, failed testing. View results
- codesniffer_fixes.patch Interdiff of automated coding standards fixes only.

  • gabesullice committed 765d69d on 8.x-2.x 
    Issue #2990532 by gabesullice: Drupal core compatibility: Terms are now...
gabesullice’s picture

gabesullice
Primary language English
commented
Status: Needs work » Fixed
StatusFileSize
new interdiff-commit.txt479 bytes

Committing this even though it doesn't completely make tests pass. The remaining failures are outside the scope of this issue.

#2976334: Allow Custom blocks to be set as non-reusable adding access restriction based on where it was used. has been backported to 8.6 since we fixed it for 8.7+
#2990133: Fix deprecation error in 8.5.x caused by Symfony\Component\HttpKernel\Controller\ControllerResolver::getArguments() is a Drupal core issue that is being resolved upstream.

wim leers’s picture

wim leers
Location Ghent 🇧🇪🇪🇺
commented

Needs backport to 8.x-1.x, because this change is causing those tests to also fail: https://www.drupal.org/pift-ci-job/1035236. OTOH, perhaps we don't care about the 1.x branch's tests failing against the next core minor, especially for failures like this, where everything actually works just fine, and it's merely expectations that need to be updated?

gabesullice’s picture

gabesullice
Primary language English
commented

See #2990552-7: Followup to #2986383: Custom content blocks are now reusable in 8.6 also

gabesullice’s picture

gabesullice
Primary language English
commented
Assigned: gabesullice » Unassigned

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.