Comments

Wim Leers created an issue. See original summary.

wim leers’s picture

Status: Active » Needs review
StatusFileSize
new2.34 KB

This updates all user-facing strings.

Before updating all comments too, we should first confirm that this is something we want to do.

e0ipso’s picture

I like JSON API the most. Just because it's the status quo.

Also updating external documents, articles, 3rd party software, video tutorials,... is very hard. Leaving it as is is the minimum effort.

I think Gabe also said years ago that his preference was JSON API. Let's see if he still has that opinion nowadays.

wim leers’s picture

WFM, but if pretty much everybody/everything else, including the spec writes JSON:API, that's weird too.

There's no good choice here.

It's a bad spec name :)

gabesullice’s picture

Status: Needs review » Closed (works as designed)
StatusFileSize
new13.5 KB
new12.44 KB
new20.71 KB
new28.12 KB
new56.68 KB

I think Gabe also said years ago that his preference was JSON API. Let's see if he still has that opinion nowadays.

Yep, you remembered correctly!

And I do still feel like "JSON API" is correct.

WFM, but if pretty much everybody/everything else, including the spec writes JSON:API, that's weird too.

FWIW, less than 50% of respondents said they prefer "JSON:API". IOW, 53% do not use "JSON:API".

The spec does not write "JSON:API". The only place it appears that way is in the logo, and that's because it's emulating JSON: {json:api}

Everywhere that the name is actually written, it's "JSON API". See the many attached screenshots :)

gabesullice’s picture

Status: Closed (works as designed) » Active

Count me contradicted: https://github.com/json-api/json-api/pull/1318

Given this official endorsement, I've changed my mind. @e0ipso, thoughts?

e0ipso’s picture

Yeah, that changes things. Let's do it.

gabesullice’s picture

Status: Active » Reviewed & tested by the community

I think this change could happen before 2.0 is stable. In fact, that might be preferable.

I'll leave this as RTBC and let another maintainer commit it, if they agree.

wim leers’s picture

Status: Reviewed & tested by the community » Needs review
StatusFileSize
new141.54 KB

In fact, that might be preferable.

Indeed.

But this can't be RTBC yet, see #2:

Before updating all comments too, we should first confirm that this is something we want to do.

wim leers’s picture

Changed the project name & page!

wim leers’s picture

Title: s/JSON API/JSON:API/ ? » s/JSON API/JSON:API/

It's no longer a question; it's happening.

wim leers’s picture

I'd commit this, but this will A) require every patch to be rebased, B) is trivial yet huge, and therefore I think we should get explicit +1s from all maintainers.

gabesullice’s picture

Status: Needs review » Reviewed & tested by the community

I think we should get explicit +1s from all maintainers.

I'm very confused. See #7 and #8. Is that not explicit +1?

Ohh, I get it. I didn't see your new patch. That's what needs explicit +1. I was thinking we would just commit the public facing changes.

I'm fine with the large patch. +1 lol.

gabesullice’s picture

Assigned: Unassigned » e0ipso

Assigning to @e0ipso for commit or +1.

  • e0ipso committed 3f59588 on 8.x-2.x authored by Wim Leers
    Issue #3007274 by Wim Leers, gabesullice, e0ipso: s/JSON API/JSON:API/
    
e0ipso’s picture

Status: Reviewed & tested by the community » Fixed

Fixed!

wim leers’s picture

🎉

wim leers’s picture

Let the rebase party begin 🎉 🙈 😄

(Fortunately, we're pretty much at an all-time low in number of patches being reviewed, since we're pretty much bug-free now 🤘)

gabesullice’s picture

Assigned: e0ipso » Unassigned

🎉

wim leers’s picture

  • gabesullice committed b5d9167 on 8.x-2.x authored by Wim Leers
    Issue #3015343 by Wim Leers: Follow-up for #3007274: s/JSON API/JSON:API...
wim leers’s picture

FYI: I also just updated all documentation at https://www.drupal.org/docs/8/modules/jsonapi and its subpages.

gabesullice’s picture

FYI: I also just updated all documentation at https://www.drupal.org/docs/8/modules/jsonapi and its subpages.

Oh, I know. RIP my inbox.

wim leers’s picture

Oh, I know. RIP my inbox.

😂

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.