Per discussion in #2996576: Coding Standards: Back to 0 violations, I think we may want to fail the build altogether in case of CS violations. See https://www.drupal.org/drupalorg/docs/drupal-ci/customizing-drupalci-tes....

CommentFileSizeAuthor
#4 3000299-4.patch605 byteswim leers
#2 3000299-2.patch542 byteswim leers

Comments

Wim Leers created an issue. See original summary.

wim leers’s picture

wim leers
Location Ghent 🇧🇪🇪🇺
commented
Status: Active » Needs review
StatusFileSize
new 3000299-2.patch542 bytes
wim leers’s picture

wim leers
Location Ghent 🇧🇪🇪🇺
commented
Issue summary: View changes
wim leers’s picture

wim leers
Location Ghent 🇧🇪🇪🇺
commented
StatusFileSize
new 3000299-4.patch605 bytes

Perhaps even this, to ensure 100% of JSON API complies, and not just the changed files.

gabesullice’s picture

gabesullice
Primary language English
commented
Status: Needs review » Reviewed & tested by the community
wim leers’s picture

wim leers
Location Ghent 🇧🇪🇪🇺
commented
Status: Reviewed & tested by the community » Fixed

  • Wim Leers committed 39d9216 on 8.x-2.x 
    Issue #3000299 by Wim Leers: Let phpcs violations fail the build on...
wim leers’s picture

wim leers
Location Ghent 🇧🇪🇪🇺
commented
Status: Reviewed & tested by the community » Fixed

Despite #6 marking it as Fixed, the issue status is actually still RTBC. Probably because #6 and #7 cross-posted.

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.