Coding Standards: Back to 0 violations

👍

These tend to come up from time to time. I think that we can avoid them using the right tooling.

In another issue I wrote:

I use git hooks to make sure DCS don't go to d.o https://asciinema.org/a/pqa3uRQwf9Uq6d4I7iaQf1WxZ

If you are interested on that I can share the setup for contrib development.

Maybe we can ensure that maintainers have something like this to avoid committing code with violations.

Thoughts?

Maybe we can ensure that maintainers have something like this to avoid committing code with violations.

I think the solution is not to have commit hooks on each developer's machine, but for coding standards violations to cause tests to fail on d.o.

@Wim Leers to me the solution is whatever gets the job done. I can install the tooling in my local and that will get the job done, I cannot change d.o tooling that easily. I think it's reasonable to have the tooling installed in the maintainer machines (just 4 machines), which is the centralized place where code goes into the repo.

Quoting core's drupalci.yml:

      phpcs:
        # phpcs will use core's specified version of Coder.
        sniff-all-files: false
        halt-on-fail: false

If we change that to halt-on-fail: true for JSON API, we're done :) This is only possible since a few months: see https://www.drupal.org/drupalorg/docs/drupal-ci/customizing-drupalci-tes....

Created #3000299: Let phpcs violations fail the build on DrupalCI for #11/#12. :)