Problem/Motivation

As described in #2952293: Branch next major: version 2, requiring Drupal core >=8.5, one of the motivations is:

  1. Enforce >=8.5, which will allow us to drop some BC code (specially around isInternal features).

Proposed resolution

Remove <=8.5 BC layer code.

Remaining tasks

Do it.

User interface changes

None.

API changes

None.

Data model changes

None.

CommentFileSizeAuthor
#4 2984607-4.patch34.89 KBwim leers
#4 interdiff.txt621 byteswim leers
#2 2984607-2.patch34.58 KBwim leers

Comments

Wim Leers created an issue. See original summary.

wim leers’s picture

wim leers
Location Ghent 🇧🇪🇪🇺
commented
Title: Remove Drupal core <=8.5 BC layer code » Remove Drupal core <=8.5 BC layer code and require Drupal >=8.5
Assigned: wim leers » Unassigned
Status: Active » Needs review
StatusFileSize
new 2984607-2.patch34.58 KB

Status: Needs review » Needs work

The last submitted patch, 2: 2984607-2.patch, failed testing. View results

wim leers’s picture

wim leers
Location Ghent 🇧🇪🇪🇺
commented
Status: Needs work » Needs review
StatusFileSize
new interdiff.txt621 bytes
new 2984607-4.patch34.89 KB

A small copy/paste mistake was made in #2932031: Comprehensive JSON API integration test coverage phase 2: for every entity type, complex use-cases, that's causing this failure. Easy fix :)

gabesullice’s picture

gabesullice
Primary language English
commented
Status: Needs review » Reviewed & tested by the community

💯

wim leers’s picture

wim leers
Location Ghent 🇧🇪🇪🇺
commented
Title: Remove Drupal core <=8.5 BC layer code and require Drupal >=8.5 » Remove Drupal core <8.5 BC layer code and require Drupal >=8.5
Status: Reviewed & tested by the community » Fixed

  • Wim Leers committed 9b80edc on 8.x-2.x 
    Issue #2984607 by Wim Leers, gabesullice: Remove Drupal core...

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.

e0ipso’s picture

e0ipso
Primary language Catalan
Location Can Picafort
commented

JSON API Extras was relying on shouldBeInternalResourceType which this issue removed.

I'll fix this in JSON API Extras.