Closed (fixed)
Project:
JSON:API
Version:
8.x-1.x-dev
Component:
Code
Priority:
Normal
Category:
Task
Assigned:
Unassigned
Reporter:
Created:
10 Jan 2017 at 13:19 UTC
Updated:
26 Jan 2017 at 11:54 UTC
Jump to comment: Most recent, Most recent file
Comments
Comment #2
skyredwangThis patch removed
CurrentContextInterfaceandFieldResolverInterfaceinterfacesComment #3
wim leersStep 1: remove
CurrentContextInterface.Comment #4
wim leersStep 2: remove
FieldResolverInterface.Comment #5
wim leersStep 3: remove
LinkManagerInterface.Comment #6
wim leersStep 4: remove
ErrorHandlerInterface+ErrorBase.Comment #7
wim leersStep 5: remove
QueryBuilderInterface.Comment #8
wim leersStep 6: remove
EntityCollectionInterface.Comment #9
wim leersStep 7: remove
DocumentRootNormalizerValueInterface.Comment #10
wim leersStep 8: remove
EntityNormalizerValueInterface.Comment #11
wim leersStep 9: remove
RelationshipItemNormalizerValueInterface.Comment #12
wim leersStep 10: remove
FieldItemNormalizerValueInterface.Comment #13
wim leersStep 11: remove
RelationshipNormalizerValueInterface.Comment #14
wim leers@skyredwang: I'm sorry that I didn't build on top of your patches, but as you can see, the issue was assigned to me. I'd been working on it all this time so I could post a clear set of steps, and green patches only, as you can see in comments #3 through #13.
However, that makes you excellently positioned to review this patch :)
Comment #15
hampercm commentedA few docblock fixes needed:
Typo: publicI
This docblock seems to be for getRequestLink(). (was incorrect in the interface as well)
no @return
This looks like the wrong class
Comment #16
wim leersAll of that except the last bit are pre-existing bugs that were just moved. Fixed them all.
The last one is a bug that I already fixed. Look at the logic of that function and what it actually returns :)
Comment #17
e0ipsoReviewing this
Comment #19
e0ipso