Support for Drupal 7 is ending on 5 January 2025—it’s time to migrate to Drupal 10! Learn about the many benefits of Drupal 10 and find migration tools in our resource center.
- I found it mighty confusing that
\Drupal\jsonapi\Plugin\FileDownloadUrl
lives in thesrc/Plugin
directory. I didn't understand why it's listed as a plugin, even though it doesn't even have an annotation. Turns out my confusion is correct: it's not a plugin. It's just a class. - If anything, this belongs in
src/Field
(or just insrc
). jsonapi_entity_base_field_info()
describes this as a work-around until #2517030: Add a URL formatter for the image field lands. But that issue landed, and it didn't fix it yet — it's #2825487: Fix normalization of File entities: file entities should expose the file URL as a computed property on the 'uri' base field that will fix it. So we should update this.
Comment | File | Size | Author |
---|---|---|---|
#4 | 2831127--interdiff--2-4.txt | 515 bytes | e0ipso |
#4 | 2831127--file-download-rename--4.patch | 1.87 KB | e0ipso |
| |||
#2 | 2831127-2.patch | 1.51 KB | Wim Leers |
Comments
Comment #2
Wim LeersComment #4
e0ipsoMinor fix added.
Comment #5
Wim LeersRTBC, except that the test still lives in the wrong place, it should be moved. But that can happen on commit, or just at a later time.
Comment #7
e0ipso