Fix what Wim pointed out in #2793809-22: [FEATURE] Provide direct download URLs for files and images.

CommentFileSizeAuthor
#3 2797823--documentation-for-2793809--3.patch570 bytese0ipso

Comments

e0ipso created an issue. See original summary.

wim leers’s picture

wim leers
Location Ghent 🇧🇪🇪🇺
commented
Issue summary: View changes

Updated issue summary to use nice d.o links.

e0ipso’s picture

e0ipso
Primary language Catalan
Location Can Picafort
commented
Status: Active » Needs review
StatusFileSize
new 2797823--documentation-for-2793809--3.patch570 bytes

I'm not going to be using \Drupal\file\Entity\File::getFileUri() because I want the uri with all the array(array('value' => …)).

Let me know if that is what you had in mind.

wim leers’s picture

wim leers
Location Ghent 🇧🇪🇪🇺
commented

I don't understand that.

+++ b/src/Plugin/FileDownloadUrl.php
@@ -0,0 +1,63 @@
+  protected function getUris() {
+    return $this->getEntity()->get('uri')->getValue();
+  }
+

Compare this with File::getFileUri():

  public function getFileUri() {
    return $this->get('uri')->value;
  }

Are you saying that getValue() returns ['value' => X], and ->value returns X? I thought they both returned the same?

  • e0ipso committed 8b24727 on 8.x-1.x 
    Issue #2797823 by e0ipso: [CLEANUP] Indicate that the file URL is a...
e0ipso’s picture

e0ipso
Primary language Catalan
Location Can Picafort
commented

Are you saying that getValue() returns ['value' => X], and ->value returns X? I thought they both returned the same?

Yes. That is what I observed.

I committed this before I forgot about this.

e0ipso’s picture

e0ipso
Primary language Catalan
Location Can Picafort
commented
Status: Needs review » Fixed

This can probably be closed.

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.