Problem/Motivation

The error format for the spec should apply to the errors in the normalization.

Proposed resolution

Use the error handler and catch the Http exceptions.

CommentFileSizeAuthor
#10 2766147--interdiff--9-10.txt2.63 KBe0ipso
#10 2766147--error-handling-serialization--10.patch7.6 KBe0ipso
#9 2766147--error-handling-serialization--9.patch6.54 KBe0ipso
#9 2766147--interdiff--8-9.txt945 bytese0ipso
#8 interdiff.txt823 bytesdawehner
#8 2766147-8.patch6.57 KBdawehner
#3 2766147--error-handling-serialization--3.patch5.86 KBe0ipso

Comments

e0ipso created an issue. See original summary.

e0ipso’s picture

e0ipso
Primary language Catalan
Location Can Picafort
commented
Related issues: +#2738269: [FEATURE] Implement expected error format for JSON API
e0ipso’s picture

e0ipso
Primary language Catalan
Location Can Picafort
commented
StatusFileSize
new 2766147--error-handling-serialization--3.patch5.86 KB

Added patch and extra testing.

e0ipso’s picture

e0ipso
Primary language Catalan
Location Can Picafort
commented
Status: Active » Fixed
e0ipso’s picture

e0ipso
Primary language Catalan
Location Can Picafort
commented
Status: Fixed » Needs review

Status: Needs review » Needs work

The last submitted patch, 3: 2766147--error-handling-serialization--3.patch, failed testing.

The last submitted patch, 3: 2766147--error-handling-serialization--3.patch, failed testing.

dawehner’s picture

dawehner
Primary language German
commented
Status: Needs work » Needs review
StatusFileSize
new 2766147-8.patch6.57 KB
new interdiff.txt823 bytes

There we go.

e0ipso’s picture

e0ipso
Primary language Catalan
Location Can Picafort
commented
StatusFileSize
new 2766147--interdiff--8-9.txt945 bytes
new 2766147--error-handling-serialization--9.patch6.54 KB

Process regular exceptions as well, as demonstrated in https://www.youtube.com/watch?v=L7matnu03iI&list=PLZOQ_ZMpYrZsyO-3IstImK....

e0ipso’s picture

e0ipso
Primary language Catalan
Location Can Picafort
commented
StatusFileSize
new 2766147--error-handling-serialization--10.patch7.6 KB
new 2766147--interdiff--9-10.txt2.63 KB

Small refactor for DRYer code. No more changes now, I promise.

  • dawehner committed 40fd2f6 on 8.x-1.x authored by e0ipso 
    Issue #2766147 by e0ipso, dawehner: [BUGFIX] Apply error format during...
dawehner’s picture

dawehner
Primary language German
commented
Status: Needs review » Fixed

Works for me :)

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.