Problem/Motivation

We want to support adding elements to a to-many relationship.

Proposed resolution

Implement the specification.

CommentFileSizeAuthor
#10 2738117--interdiff--7-10.txt13.46 KBe0ipso
#10 2738117--post-relationships--10.patch33.62 KBe0ipso
#7 2738117--interdiff--3-7.txt9.3 KBe0ipso
#7 2738117--post-relationships--7.patch23.52 KBe0ipso
#3 2738117--post-relationships--3.patch17.68 KBe0ipso

Comments

e0ipso created an issue. See original summary.

e0ipso’s picture

e0ipso
Primary language Catalan
Location Can Picafort
commented
Parent issue: » #2738129: [META] Add support for the relationship operations
e0ipso’s picture

e0ipso
Primary language Catalan
Location Can Picafort
commented
Status: Active » Needs review
StatusFileSize
new 2738117--post-relationships--3.patch17.68 KB

Adds initial support.

Missing tasks:

  • Use dependency injection for the entity reference serialization.
  • Check for duplicates before adding the relationship.
  • Add tests.
e0ipso’s picture

e0ipso
Primary language Catalan
Location Can Picafort
commented
Status: Needs review » Needs work

The last submitted patch, 3: 2738117--post-relationships--3.patch, failed testing.

The last submitted patch, 3: 2738117--post-relationships--3.patch, failed testing.

e0ipso’s picture

e0ipso
Primary language Catalan
Location Can Picafort
commented
StatusFileSize
new 2738117--post-relationships--7.patch23.52 KB
new 2738117--interdiff--3-7.txt9.3 KB

Finish the missing tasks and fix the tests. This is still missing tests for the new features.

e0ipso’s picture

e0ipso
Primary language Catalan
Location Can Picafort
commented
Status: Needs work » Needs review
e0ipso’s picture

e0ipso
Primary language Catalan
Location Can Picafort
commented
Status: Needs review » Needs work
e0ipso’s picture

e0ipso
Primary language Catalan
Location Can Picafort
commented
Status: Needs work » Needs review
StatusFileSize
new 2738117--post-relationships--10.patch33.62 KB
new 2738117--interdiff--7-10.txt13.46 KB

Added test coverage. This is ready to be reviewed.

e0ipso’s picture

e0ipso
Primary language Catalan
Location Can Picafort
commented
Status: Needs review » Fixed

This was merged.

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.