I have many drupal installs that do not live at "/", so to speak. So hard-coded relative links to "/admin/settings/ip_login", for example, are broken.

In D6 (and I believe also D7), base_path() should be used instead of hard-coding a "/".

Attached is a tested, working patch for the 6.x-2.x branch (this is the version I'm using).

I also noticed that in the master branch, ip_login.module hard-codes "/admin..." on line 67:

       array('@permissions-link' => '/admin/user/permissions#module-ip_login')

I'll leave the master branch to be patched by the D7 experienced folks (if needed).

CommentFileSizeAuthor
ip_login_base_path_fix_6.x-2.x.patch541 bytesclaar
Support from Acquia helps fund testing for Drupal Acquia logo

Comments

Status: Needs review » Needs work

The last submitted patch, ip_login_base_path_fix_6.x-2.x.patch, failed testing.

Jim Kirkpatrick’s picture

Jim Kirkpatrick CreditAttribution: Jim Kirkpatrick commented

Thanks for the report and patch... Been a busy man but will commit something similar ASAP.