Just tried to install the latest and got this error:

Parse error: syntax error, unexpected '[' in invite.install on line 226

Site was in WSOD mode...

Reinstalled - Version: 7.x-4.0-beta3 and site is back.

CommentFileSizeAuthor
#11 add_field_syntax_fix-2831307-11.patch696 bytesabarpetia
#9 add_field_syntax_fix-11801581-9.patch696 bytesabarpetia
#3 field_syntax_fix-2831307-3.patch503 bytesabarpetia

Comments

Infinitee created an issue. See original summary.

Infinitee’s picture

Infinitee commented
Issue summary: View changes
abarpetia’s picture

abarpetia commented
Version: 7.x-4.0-beta4 » 7.x-4.x-dev
StatusFileSize
new field_syntax_fix-2831307-3.patch503 bytes

It's a syntax error. Please try attached patch.

abarpetia’s picture

abarpetia commented
Status: Active » Needs review
Infinitee’s picture

Infinitee commented

Confirmed that the patch works!

Small typo in notes...

// Calculate and store invite status from exisiting data.

Should be:
// Calculate and store invite status from existing data.

Infinitee’s picture

Infinitee commented
Status: Needs review » Fixed
ckng’s picture

ckng
Primary language English
commented
Status: Fixed » Needs work

@Infinitee, don't set status to Fixed, it closes the issue. I think what you are looking for is "Reviewed and tested by community" if reviewed or "Need Works" since there are more changes required.

Infinitee’s picture

Infinitee commented
Version: 7.x-4.x-dev » 7.x-4.0-beta4
Status: Needs work » Reviewed & tested by the community

Resetting to "Reviewed and tested by community" as per ckng's request.

abarpetia’s picture

abarpetia commented
StatusFileSize
new add_field_syntax_fix-11801581-9.patch696 bytes

@infinitee: Thanks for that typo and RTBC. Here is the new patch which fixing field syntax and typo.

abarpetia’s picture

abarpetia commented
Version: 7.x-4.0-beta4 » 7.x-4.x-dev
Assigned: Unassigned » abarpetia

This patch is created against 7.x-4.x-dev branch but will also work on 7.x-4.0-beta4.
Changing version.

abarpetia’s picture

abarpetia commented
StatusFileSize
new add_field_syntax_fix-2831307-11.patch696 bytes

Wrong issue number in patch file name.

SpartyDan’s picture

SpartyDan commented
Status: Reviewed & tested by the community » Fixed

Patch committed.

My apologies for this issue. The coding standard for Drupal 7 require the long array, array(), syntax but my employer's coding standard requires the short array, [], syntax.

This should not be an issue for anyone running PHP >= 5.4.

  • SpartyDan committed 16d390e on 7.x-4.x 
    Issue #2831307 by abarpetia, Infinitee: Parse error: syntax error,...
SpartyDan’s picture

SpartyDan commented
Assigned: abarpetia » Unassigned

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.