To replicate, try to change the format in admin/settings/filters nothing happens.

CommentFileSizeAuthor
#1 input_formats-876770.patch776 bytesisaakordonez

Comments

isaakordonez’s picture

Status: Active » Patch (to be ported)
StatusFileSize
new776 bytes

Hi, I create a patch for this.

dagmar’s picture

Status: Patch (to be ported) » Needs work

Hi, thanks, but this doesn't fix the problem. You see, the problem is

$form = array();

This removes the $form['#submit'] function in the form array, and for this reason the button doesn't perform nothing when it is pressed.

I would accept a patch to fix that. Thanks again.

dagmar’s picture

Status: Needs work » Fixed
dagmar’s picture

Version: 6.x-1.0-beta2 » 6.x-1.0-beta3
Status: Fixed » Needs work

Sadly the last commit doesn't fix the problem either. I think the issue here is

$form = array();

This is removing more info that is needed.

jaydub’s picture

I don't have more time today to check but from a quick look I think the problem is that by basically unsetting the $form and recreating it to suit the purposes of Input Formats, you have lost a lot of Form API stuff that is needed to process the form such as $form['#parameters'], $form['#build_id'], $form['#type'], $form['#programmed'], $form['#token'], etc. I'll take a run at refactoring the form_alter to actually alter and not wipe and rebuild to see if that fixes the problem.

dagmar’s picture

Status: Needs work » Fixed

Don't worry, I already have committed a patch for this issue. Thanks anyway. http://drupal.org/cvs?commit=408630

Status: Fixed » Closed (fixed)

Automatically closed -- issue fixed for 2 weeks with no activity.