The Inline Entity Menu Form submodule sends a response in Ajax format instead of the usual one, when editing a menu with an additional field from the Item Extra Field module.

CommentFileSizeAuthor
#14 inline_entity_menu_form-fix_problem_with_menu_editing.patch2.18 KBznak

Issue fork inline_entity_form-3398615

Command icon Show commands

Start within a Git clone of the project using the version control instructions.

Or, if you do not have SSH keys set up on git.drupalcode.org:

About issue forks

Comments

david-b created an issue. See original summary.

david-b opened merge request !93

podarok’s picture

podarok
🇺🇦 he/him/his
Primary language Ukrainian
Location Ukraine
commented
Version: 2.0.x-dev » 2.0.0-rc10
Status: Active » Needs review

tnx

david-b’s picture

david-b commented
Assigned: david-b » Unassigned
geek-merlin’s picture

geek-merlin
Primary language German
Location Freiburg, Germany
commented
Version: 2.0.0-rc10 » 3.x-dev

Bulk retarget.

geek-merlin’s picture

geek-merlin
Primary language German
Location Freiburg, Germany
commented
Status: Needs review » Postponed

Postponed on #3371257: Add support for the menu entity..

david-b changed the visibility of the branch 3398615-save to hidden.

david-b changed the visibility of the branch 3398615-save to active.

david-b opened merge request !95

podarok’s picture

podarok
🇺🇦 he/him/his
Primary language Ukrainian
Location Ukraine
commented
Status: Postponed » Reviewed & tested by the community

Please, add me as a co-maintainer back to this project

podarok’s picture

podarok
🇺🇦 he/him/his
Primary language Ukrainian
Location Ukraine
commented
Status: Reviewed & tested by the community » Postponed

Ah, I see.
We don't have resources for writing tests at this point.
We'll discuss internally and decide if we should go with separate module

Weird I was removed from the maintainers without any notification in advance. What's the reason of this activity if no response from maintainer?
https://www.drupal.org/project/inline_entity_form/issues/3401657#comment...

It is very confusing to put dependency from whole distribution to current module, but then removed as a maintainer without any message via PM or Slack

Very unreliable group of maintainers

podarok’s picture

podarok
🇺🇦 he/him/his
Primary language Ukrainian
Location Ukraine
commented
Assigned: Unassigned » podarok
Status: Postponed » Patch (to be ported)

work will be moved to https://www.drupal.org/project/inline_entity_menu_form in Q1 2024
Please, do not remove tags of 2.x branch just yet from current module in order to avoid breaking 500+ sites.

Thank you and sorry for the inconvenience

znak’s picture

znak commented
Status: Patch (to be ported) » Needs review
StatusFileSize
new inline_entity_menu_form-fix_problem_with_menu_editing.patch2.18 KB

I have encountered a problem with editing/adding menu items when using the block with Menu reference in LB. When we try to add or edit an item in the modal window when submitting the form, it goes to the edit/add page of the corresponding menu item instead of closing the modal window and returning to viewing all available links.

I made patch the same as we have here - https://git.drupalcode.org/project/inline_entity_form/-/merge_requests/9... and it works. Please, check it